diff options
| author | Jens Remus <jremus@linux.ibm.com> | 2024-02-13 13:21:34 +0100 |
|---|---|---|
| committer | Jens Remus <jremus@linux.ibm.com> | 2024-05-16 13:32:22 +0200 |
| commit | fff478811a62a277966fa3ea64d4be1c1e19c2af (patch) | |
| tree | 689e4329d7ad056a75488d1eca533028daea0d1d | |
| parent | 15ebdb47085fa46e8c70b84962024706604cf4dd (diff) | |
| download | fsf-binutils-gdb-fff478811a62a277966fa3ea64d4be1c1e19c2af.zip fsf-binutils-gdb-fff478811a62a277966fa3ea64d4be1c1e19c2af.tar.gz fsf-binutils-gdb-fff478811a62a277966fa3ea64d4be1c1e19c2af.tar.bz2 | |
gas: Warn if SFrame FDE is skipped due to non-default return column
Print a warning message if SFrame FDE is skipped due to a non-default
DWARF return column (i.e. return address (RA) register number). This
may be caused by the use of CFI directive .cfi_return_column with a
non-default return address (RA) register number in the processed
assembler source code.
Warning: skipping SFrame FDE due to non-default DWARF return column
gas/
* gen-sframe.c: Warn if SFrame FDE is skipped due to non-default
DWARF return column.
gas/testsuite/
* gas/cfi-sframe/common-empty-3.d: Update test case to expect
for new warning message when SFrame FDE is skipped due to
a non-default DWARF return column.
Reviewed-by: Andreas Krebbel <krebbel@linux.ibm.com>
Reviewed-by: Indu Bhagat <indu.bhagat@oracle.com>
Signed-off-by: Jens Remus <jremus@linux.ibm.com>
| -rw-r--r-- | gas/gen-sframe.c | 10 | ||||
| -rw-r--r-- | gas/testsuite/gas/cfi-sframe/common-empty-3.d | 1 |
2 files changed, 8 insertions, 3 deletions
diff --git a/gas/gen-sframe.c b/gas/gen-sframe.c index d363522..9da34dc 100644 --- a/gas/gen-sframe.c +++ b/gas/gen-sframe.c @@ -1345,9 +1345,12 @@ sframe_do_fde (struct sframe_xlate_ctx *xlate_ctx, xlate_ctx->dw_fde = dw_fde; - /* If the return column is not RIP, SFrame format cannot represent it. */ + /* SFrame format cannot represent a non-default DWARF return column reg. */ if (xlate_ctx->dw_fde->return_column != DWARF2_DEFAULT_RETURN_COLUMN) - return SFRAME_XLATE_ERR_NOTREPRESENTED; + { + as_warn (_("skipping SFrame FDE due to non-default DWARF return column")); + return SFRAME_XLATE_ERR_NOTREPRESENTED; + } /* Iterate over the CFIs and create SFrame FREs. */ for (cfi_insn = dw_fde->data; cfi_insn; cfi_insn = cfi_insn->next) @@ -1357,7 +1360,8 @@ sframe_do_fde (struct sframe_xlate_ctx *xlate_ctx, if (err != SFRAME_XLATE_OK) { /* Skip generating SFrame stack trace info for the function if any - offending CFI is encountered by sframe_do_cfi_insn (). */ + offending CFI is encountered by sframe_do_cfi_insn (). Warning + message already printed by sframe_do_cfi_insn (). */ return err; /* Return the error code. */ } } diff --git a/gas/testsuite/gas/cfi-sframe/common-empty-3.d b/gas/testsuite/gas/cfi-sframe/common-empty-3.d index 5914c62..d17521d 100644 --- a/gas/testsuite/gas/cfi-sframe/common-empty-3.d +++ b/gas/testsuite/gas/cfi-sframe/common-empty-3.d @@ -1,4 +1,5 @@ #as: --gsframe +#warning: skipping SFrame FDE due to non-default DWARF return column #objdump: --sframe=.sframe #name: SFrame supports only default return column #... |