aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom de Vries <tdevries@suse.de>2023-04-25 08:33:56 +0200
committerTom de Vries <tdevries@suse.de>2023-04-25 08:33:56 +0200
commit0d00a5f9d429c7cbae87b9d1057fb4f9e4ae18c2 (patch)
tree6bac754bc07752004aaa97a3c9a6cbedab431b8c
parent25035d2122ea23c943f0c77360dfc0770750a2e6 (diff)
downloadfsf-binutils-gdb-0d00a5f9d429c7cbae87b9d1057fb4f9e4ae18c2.zip
fsf-binutils-gdb-0d00a5f9d429c7cbae87b9d1057fb4f9e4ae18c2.tar.gz
fsf-binutils-gdb-0d00a5f9d429c7cbae87b9d1057fb4f9e4ae18c2.tar.bz2
[gdb/testsuite] Add warning for timeout in accept_gdb_output
In accept_gdb_output we have: ... timeout { # Assume a timeout means we somehow missed the # expected result, and carry on. return 0 } ... The timeout is silent, and though in some places the return value is checked, this is not done consistently, and consequently there are silent timeouts when running the TUI testsuite (gdb.tui/*.exp and gdb.python/tui*.exp). Each timeout is 10 seconds, and there are 5 in total in the TUI tests, taking 50 seconds overall: ... real 1m0.275s user 0m10.440s sys 0m1.343s ... With an entire testsuite run taking about 30 minutes, that is about 2.5% of the time spent waiting in TUI tests. Let's make the timeouts visible using a warning, such that they can be fixed. Tested on x86_64-linux.
-rw-r--r--gdb/testsuite/lib/tuiterm.exp2
1 files changed, 2 insertions, 0 deletions
diff --git a/gdb/testsuite/lib/tuiterm.exp b/gdb/testsuite/lib/tuiterm.exp
index 05edfe9..ff38af0 100644
--- a/gdb/testsuite/lib/tuiterm.exp
+++ b/gdb/testsuite/lib/tuiterm.exp
@@ -707,6 +707,8 @@ namespace eval Term {
timeout {
# Assume a timeout means we somehow missed the
# expected result, and carry on.
+ warning "timeout in accept_gdb_output"
+ dump_screen
return 0
}
}