aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon Marchi <simon.marchi@ericsson.com>2017-09-05 16:43:07 +0200
committerSimon Marchi <simon.marchi@ericsson.com>2017-09-05 17:41:03 +0200
commitfc8098275751f48404a547fd027b2671c5350302 (patch)
tree3f35c22a0d6bf40e56d2ad5e87d81d7af14f3e42
parentd2fcdd85466668c06dda0fa02ac8c1f4cef3910d (diff)
downloadfsf-binutils-gdb-fc8098275751f48404a547fd027b2671c5350302.zip
fsf-binutils-gdb-fc8098275751f48404a547fd027b2671c5350302.tar.gz
fsf-binutils-gdb-fc8098275751f48404a547fd027b2671c5350302.tar.bz2
Improve "'g' reply is is to long" error message
... by adding the expected size, and the received size. I found this useful when debugging gdbarch/remote issues, since it gives a hint of what gdb expects and what the remote sent. gdb/ChangeLog: * remote.c (process_g_packet): Update error message.
-rw-r--r--gdb/ChangeLog4
-rw-r--r--gdb/remote.c3
2 files changed, 6 insertions, 1 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 3ba07ce..2792208 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2017-09-05 Simon Marchi <simon.marchi@ericsson.com>
+
+ * remote.c (process_g_packet): Update error message.
+
2017-09-05 Yao Qi <yao.qi@linaro.org>
* configure.tgt (gdb_target_obs): Add i386.o for x86_64-*
diff --git a/gdb/remote.c b/gdb/remote.c
index 3347dd8..abeef0d 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -7591,7 +7591,8 @@ process_g_packet (struct regcache *regcache)
/* Further sanity checks, with knowledge of the architecture. */
if (buf_len > 2 * rsa->sizeof_g_packet)
- error (_("Remote 'g' packet reply is too long: %s"), rs->buf);
+ error (_("Remote 'g' packet reply is too long (expected %ld bytes, got %d "
+ "bytes): %s"), rsa->sizeof_g_packet, buf_len / 2, rs->buf);
/* Save the size of the packet sent to us by the target. It is used
as a heuristic when determining the max size of packets that the