aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Tromey <tom@tromey.com>2020-03-28 09:25:41 -0600
committerTom Tromey <tom@tromey.com>2020-03-28 09:25:41 -0600
commit4d1b9ab645d9ce72aad15011264dd9b2e52a57e8 (patch)
tree39327129ddd3335a47370d6f4ebb1ffe49d9b66b
parentf1749218ff325e2074583fa7d7caf9ee09a1feb8 (diff)
downloadfsf-binutils-gdb-4d1b9ab645d9ce72aad15011264dd9b2e52a57e8.zip
fsf-binutils-gdb-4d1b9ab645d9ce72aad15011264dd9b2e52a57e8.tar.gz
fsf-binutils-gdb-4d1b9ab645d9ce72aad15011264dd9b2e52a57e8.tar.bz2
Fix comment in dwarf2/attribute.h
I noticed that a comment in dwarf2/attribute.h still referred to dwarf2_get_attr_constant_value. However, this is now a method on struct attribute. gdb/ChangeLog 2020-03-28 Tom Tromey <tom@tromey.com> * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update comment.
-rw-r--r--gdb/ChangeLog5
-rw-r--r--gdb/dwarf2/attribute.h6
2 files changed, 8 insertions, 3 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index bc4451e..82ece13 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2020-03-28 Tom Tromey <tom@tromey.com>
+ * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
+ comment.
+
+2020-03-28 Tom Tromey <tom@tromey.com>
+
* dwarf2/read.c (read_attribute_reprocess): Fix formatting.
2020-03-27 Hannes Domani <ssbssa@yahoo.de>
diff --git a/gdb/dwarf2/attribute.h b/gdb/dwarf2/attribute.h
index 483b805..69b3351 100644
--- a/gdb/dwarf2/attribute.h
+++ b/gdb/dwarf2/attribute.h
@@ -59,7 +59,7 @@ struct attribute
/* Return non-zero if ATTR's value falls in the 'constant' class, or
zero otherwise. When this function returns true, you can apply
- dwarf2_get_attr_constant_value to it.
+ the constant_value method to it.
However, note that for some attributes you must check
attr_form_is_section_offset before using this test. DW_FORM_data4
@@ -70,8 +70,8 @@ struct attribute
section offset classes, DW_FORM_data4 and DW_FORM_data8 should be
taken as section offsets, not constants.
- DW_FORM_data16 is not considered as dwarf2_get_attr_constant_value
- cannot handle that. */
+ DW_FORM_data16 is not considered as constant_value cannot handle
+ that. */
bool form_is_constant () const;