aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon Marchi <simon.marchi@efficios.com>2019-11-26 12:12:00 -0500
committerSimon Marchi <simon.marchi@efficios.com>2019-11-26 14:29:19 -0500
commit23767560e57e43d7ce3e509835b91ef2eb7e0746 (patch)
tree006f080bd1acf1c03cc79b9a25c793242534b8bb
parent6d91ce9a659f5b65bb6ad2d30d74250da342150c (diff)
downloadfsf-binutils-gdb-23767560e57e43d7ce3e509835b91ef2eb7e0746.zip
fsf-binutils-gdb-23767560e57e43d7ce3e509835b91ef2eb7e0746.tar.gz
fsf-binutils-gdb-23767560e57e43d7ce3e509835b91ef2eb7e0746.tar.bz2
Include aarch32-tdep.h in aarch32-tdep.c
The error below shows that aarch32-tdep.c is missing an include for aarch32-tdep.h, add it. CXX aarch32-tdep.o /home/smarchi/src/binutils-gdb/gdb/aarch32-tdep.c: In function ‘const target_desc* aarch32_read_description()’: /home/smarchi/src/binutils-gdb/gdb/aarch32-tdep.c:27:1: error: no previous declaration for ‘const target_desc* aarch32_read_description()’ [-Werror=missing-declarations] aarch32_read_description () ^~~~~~~~~~~~~~~~~~~~~~~~ Putting the include of aarch32-tdep.h early in aarch32-tdep.c gives us an error about target_desc not being defined. Indeed, aarch32-tdep.h uses target_desc without forward-declaring it or including the proper header. Add a forward-declaration for it. gdb/ChangeLog: * aarch32-tdep.c: Include aarch32-tdep.h. * aarch32-tdep.h: Forward-declare struct target_desc. Change-Id: Ica4be4de0fbd7f22d56a29a40fbf0a31b5abdb16
-rw-r--r--gdb/ChangeLog5
-rw-r--r--gdb/aarch32-tdep.c3
-rw-r--r--gdb/aarch32-tdep.h2
3 files changed, 10 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index b4d7eb7..6f6019c 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-11-26 Simon Marchi <simon.marchi@efficios.com>
+
+ * aarch32-tdep.c: Include aarch32-tdep.h.
+ * aarch32-tdep.h: Forward-declare struct target_desc.
+
2019-11-26 Christian Biesinger <cbiesinger@google.com>
* linux-nat.c (detach_one_lwp): Call safe_strerror instead of
diff --git a/gdb/aarch32-tdep.c b/gdb/aarch32-tdep.c
index 12d4641..5b082fc 100644
--- a/gdb/aarch32-tdep.c
+++ b/gdb/aarch32-tdep.c
@@ -16,6 +16,9 @@
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "gdbsupport/common-defs.h"
+
+#include "aarch32-tdep.h"
+
#include "gdbsupport/common-regcache.h"
#include "arch/aarch32.h"
diff --git a/gdb/aarch32-tdep.h b/gdb/aarch32-tdep.h
index 7fcea0a..eb4c70c 100644
--- a/gdb/aarch32-tdep.h
+++ b/gdb/aarch32-tdep.h
@@ -18,6 +18,8 @@
#ifndef AARCH32_TDEP_H
#define AARCH32_TDEP_H
+struct target_desc;
+
/* Get the AArch32 target description. */
const target_desc *aarch32_read_description ();