diff options
| author | Pedro Alves <pedro@palves.net> | 2021-06-21 22:25:58 +0100 |
|---|---|---|
| committer | Pedro Alves <pedro@palves.net> | 2021-09-24 17:35:37 +0100 |
| commit | fbfdbdab95001d4a543598a3caa0e0f01e05b83f (patch) | |
| tree | ca4dcb538051d3d4c894f8493f9c02e231d1ad1d | |
| parent | d8767a720e889b4b90f2a8a60a43d9fd400f4478 (diff) | |
| download | fsf-binutils-gdb-fbfdbdab95001d4a543598a3caa0e0f01e05b83f.zip fsf-binutils-gdb-fbfdbdab95001d4a543598a3caa0e0f01e05b83f.tar.gz fsf-binutils-gdb-fbfdbdab95001d4a543598a3caa0e0f01e05b83f.tar.bz2 | |
Fix all PATH problems in testsuite/gdb.perf/
Currently "make check-perf" triggers ~40 PATH messages in gdb.sum:
...
PATH: gdb.perf/backtrace.exp: python sys.path.insert(0, os.path.abspath("/home/pedro/rocm/gdb/build/gdb/../../src/gdb/testsuite/gdb.perf/lib"))
PATH: gdb.perf/backtrace.exp: python exec (open ('/home/pedro/rocm/gdb/build/gdb/testsuite/outputs/gdb.perf/backtrace/backtrace.py').read ())
...
This commit fixes them. E.g. before/after gdb.sum diff:
-PASS: gdb.perf/backtrace.exp: python import os, sys
-PASS: gdb.perf/backtrace.exp: python sys.path.insert(0, os.path.abspath("/home/pedro/rocm/gdb/build-master/gdb/../../src/gdb/testsuite/gdb.perf/lib"))
-PATH: gdb.perf/backtrace.exp: python sys.path.insert(0, os.path.abspath("/home/pedro/rocm/gdb/build-master/gdb/../../src/gdb/testsuite/gdb.perf/lib"))
-PASS: gdb.perf/backtrace.exp: python exec (open ('/home/pedro/rocm/gdb/build-master/gdb/testsuite/outputs/gdb.perf/backtrace/backtrace.py').read ())
-PATH: gdb.perf/backtrace.exp: python exec (open ('/home/pedro/rocm/gdb/build-master/gdb/testsuite/outputs/gdb.perf/backtrace/backtrace.py').read ())
+PASS: gdb.perf/backtrace.exp: setup perftest: python import os, sys
+PASS: gdb.perf/backtrace.exp: setup perftest: python sys.path.insert(0, os.path.abspath("${srcdir}/gdb.perf/lib"))
+PASS: gdb.perf/backtrace.exp: setup perftest: python exec (open ('${srcdir}/gdb.perf/backtrace.py').read ())
gdb/testsuite/
yyyy-mm-dd Pedro Alves <pedro@palves.net>
* lib/perftest.exp (PerfTest::_setup_perftest): Use
with_test_prefix. Add explicit test names to python invocations,
with "$srcdir" not expanded.
Change-Id: I50a31b04b7abdea754139509e4a34ae9263118a4
| -rw-r--r-- | gdb/testsuite/lib/perftest.exp | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/gdb/testsuite/lib/perftest.exp b/gdb/testsuite/lib/perftest.exp index de99518..205bcb5 100644 --- a/gdb/testsuite/lib/perftest.exp +++ b/gdb/testsuite/lib/perftest.exp @@ -25,9 +25,15 @@ namespace eval PerfTest { set remote_python_file [gdb_remote_download host ${srcdir}/${subdir}/${testfile}.py] # Set sys.path for module perftest. - gdb_test_no_output "python import os, sys" - gdb_test_no_output "python sys.path.insert\(0, os.path.abspath\(\"${srcdir}/${subdir}/lib\"\)\)" - gdb_test_no_output "python exec (open ('${remote_python_file}').read ())" + with_test_prefix "setup perftest" { + gdb_test_no_output "python import os, sys" + gdb_test_no_output \ + "python sys.path.insert\(0, os.path.abspath\(\"${srcdir}/${subdir}/lib\"\)\)" \ + "python sys.path.insert\(0, os.path.abspath\(\"\${srcdir}/${subdir}/lib\"\)\)" + gdb_test_no_output \ + "python exec (open ('${remote_python_file}').read ())" \ + "python exec (open ('\${srcdir}/${subdir}/${testfile}.py').read ())" + } } # A private method to do some cleanups when performance test is |