diff options
| author | Xi Ruoyao <xry111@xry111.site> | 2024-02-02 21:00:58 +0800 |
|---|---|---|
| committer | liuzhensong <liuzhensong@loongson.cn> | 2024-02-04 14:14:15 +0800 |
| commit | e92e2d654bf3140f81466c6752581d6da8da1d67 (patch) | |
| tree | a2c226121b606c8dd8c53b3a130856b0de602364 | |
| parent | 953cc7c7769e5e1360d9cbfae793b4d3d90b8801 (diff) | |
| download | fsf-binutils-gdb-e92e2d654bf3140f81466c6752581d6da8da1d67.zip fsf-binutils-gdb-e92e2d654bf3140f81466c6752581d6da8da1d67.tar.gz fsf-binutils-gdb-e92e2d654bf3140f81466c6752581d6da8da1d67.tar.bz2 | |
LoongArch: gas: Fix the types of symbols referred with %le_*_r in the symtab
When a symbol is referred with %le_{hi20,lo12,add}_r, it's definitely a
TLS symbol and we should set its type to TLS in the symtab. Otherwise
when building Perl with gcc-14 -flto, we get:
/usr/bin/ld: PL_current_context: TLS definition in
./miniperl.ltrans0.ltrans.o section .tbss mismatches non-TLS reference
in ./miniperl.ltrans1.ltrans.o
A minimal reproducer:
$ cat t1.s
.section .tbss
.globl x
x: .word 0
$ cat t2.s
f:
lu12i.w $a0, %le_hi20_r(x)
add.d $a0, $a0, $tp, %le_add_r(x)
li.w $a1, 1
st.w $a1, $a0, %le_lo12_r(x)
$ gas/as-new t1.s -o t1.o
$ gas/as-new t2.s -o t2.o
$ ld/ld-new t1.o t2.o
ld/ld-new: x: TLS definition in t1.o section .tbss mismatches
non-TLS reference in t2.o
Unfortunately this was undetected before Binutils-2.42 release because
GCC < 14 does not use %le_*_r, and without LTO it's very rare to have a
TLS LE definition and its reference in two different translation units.
So this fix should be backported to Binutils-2.42 branch too.
Signed-off-by: Xi Ruoyao <xry111@xry111.site>
(cherry picked from commit 029e52bac7f3a6dd8b39f7f3d298b73174da806b)
| -rw-r--r-- | gas/config/tc-loongarch.c | 3 | ||||
| -rw-r--r-- | gas/testsuite/gas/loongarch/tls_le_r_sym_type.d | 3 | ||||
| -rw-r--r-- | gas/testsuite/gas/loongarch/tls_le_r_sym_type.s | 6 |
3 files changed, 12 insertions, 0 deletions
diff --git a/gas/config/tc-loongarch.c b/gas/config/tc-loongarch.c index af4426b..d52e5d2e 100644 --- a/gas/config/tc-loongarch.c +++ b/gas/config/tc-loongarch.c @@ -1353,6 +1353,9 @@ md_apply_fix (fixS *fixP, valueT *valP, segT seg ATTRIBUTE_UNUSED) case BFD_RELOC_LARCH_TLS_DESC_LO12: case BFD_RELOC_LARCH_TLS_DESC64_LO20: case BFD_RELOC_LARCH_TLS_DESC64_HI12: + case BFD_RELOC_LARCH_TLS_LE_ADD_R: + case BFD_RELOC_LARCH_TLS_LE_HI20_R: + case BFD_RELOC_LARCH_TLS_LE_LO12_R: /* Add tls lo (got_lo reloc type). */ if (fixP->fx_addsy == NULL) as_bad_where (fixP->fx_file, fixP->fx_line, diff --git a/gas/testsuite/gas/loongarch/tls_le_r_sym_type.d b/gas/testsuite/gas/loongarch/tls_le_r_sym_type.d new file mode 100644 index 0000000..43bcd78 --- /dev/null +++ b/gas/testsuite/gas/loongarch/tls_le_r_sym_type.d @@ -0,0 +1,3 @@ +#readelf: -s +#... +.*TLS[ \t]+GLOBAL[ \t]+DEFAULT[ \t]+UND[ \t]+x diff --git a/gas/testsuite/gas/loongarch/tls_le_r_sym_type.s b/gas/testsuite/gas/loongarch/tls_le_r_sym_type.s new file mode 100644 index 0000000..3ccedae --- /dev/null +++ b/gas/testsuite/gas/loongarch/tls_le_r_sym_type.s @@ -0,0 +1,6 @@ +f: + lu12i.w $a0, %le_hi20_r(x) + add.d $a0, $a0, $tp, %le_add_r(x) + li.w $a1, 1 + st.w $a1, $a0, %le_lo12_r(x) + ret |