aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCary Coutant <ccoutant@google.com>2014-12-22 10:13:37 -0800
committerCary Coutant <ccoutant@google.com>2014-12-22 10:13:37 -0800
commite30880c2eeee3b43897161344bbbffd03f3a1c91 (patch)
tree97e0d58374f6fa51d4e09826edd43d1bb5c13ee0
parentf953163fe9bb5b87edb168a6ea25e2baa966750f (diff)
downloadfsf-binutils-gdb-e30880c2eeee3b43897161344bbbffd03f3a1c91.zip
fsf-binutils-gdb-e30880c2eeee3b43897161344bbbffd03f3a1c91.tar.gz
fsf-binutils-gdb-e30880c2eeee3b43897161344bbbffd03f3a1c91.tar.bz2
gold/
* powerpc.cc (Target_powerpc::relocate): Fix overflow check.
-rw-r--r--gold/ChangeLog4
-rw-r--r--gold/powerpc.cc3
2 files changed, 6 insertions, 1 deletions
diff --git a/gold/ChangeLog b/gold/ChangeLog
index f67df17..457fa6b 100644
--- a/gold/ChangeLog
+++ b/gold/ChangeLog
@@ -1,3 +1,7 @@
+2014-12-22 Cary Coutant <ccoutant@google.com>
+
+ * powerpc.cc (Target_powerpc::relocate): Fix overflow check.
+
2014-12-20 H.J. Lu <hongjiu.lu@intel.com>
PR gold/14608
diff --git a/gold/powerpc.cc b/gold/powerpc.cc
index 1407a0e..e456c85 100644
--- a/gold/powerpc.cc
+++ b/gold/powerpc.cc
@@ -7531,7 +7531,6 @@ Target_powerpc<size, big_endian>::Relocate::relocate(
Insn* iview = reinterpret_cast<Insn*>(view - 2 * big_endian);
Insn insn = elfcpp::Swap<32, big_endian>::readval(iview);
- overflow = Reloc::CHECK_SIGNED;
if ((insn & (0x3f << 26)) == 10u << 26 /* cmpli */)
overflow = Reloc::CHECK_BITFIELD;
else if (overflow == Reloc::CHECK_LOW_INSN
@@ -7542,6 +7541,8 @@ Target_powerpc<size, big_endian>::Relocate::relocate(
|| (insn & (0x3f << 26)) == 25u << 26 /* oris */
|| (insn & (0x3f << 26)) == 27u << 26 /* xoris */))
overflow = Reloc::CHECK_UNSIGNED;
+ else
+ overflow = Reloc::CHECK_SIGNED;
}
typename Powerpc_relocate_functions<size, big_endian>::Status status