aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom de Vries <tdevries@suse.de>2021-09-24 12:39:14 +0200
committerTom de Vries <tdevries@suse.de>2021-09-24 12:39:14 +0200
commitdbb17692ecd743aa0ee81d138442c63121a17cd4 (patch)
treefbc66db58f42160eb04ea8dfeb620d86cc9e5236
parentb4e4386a2e58ba6ce8d02b952f1bc6ceb8fc95d1 (diff)
downloadfsf-binutils-gdb-dbb17692ecd743aa0ee81d138442c63121a17cd4.zip
fsf-binutils-gdb-dbb17692ecd743aa0ee81d138442c63121a17cd4.tar.gz
fsf-binutils-gdb-dbb17692ecd743aa0ee81d138442c63121a17cd4.tar.bz2
[gdb/testsuite] Use pie/nopie instead of ldflags=-pie/-no-pie
I noticed two test-case that use ldflags=-pie and ldflags-no-pie, instead of the canonical pie and nopie options, which would typically also add additional_flags=-fPIE respectively additional_flags=-fno-pie. There is no indication that this is on purpose, so replace these with pie and nopie. Tested on x86_64-linux.
-rw-r--r--gdb/testsuite/gdb.base/load-command.exp2
-rw-r--r--gdb/testsuite/gdb.dwarf2/fission-loclists-pie.exp2
2 files changed, 2 insertions, 2 deletions
diff --git a/gdb/testsuite/gdb.base/load-command.exp b/gdb/testsuite/gdb.base/load-command.exp
index 6de885a..8847aff 100644
--- a/gdb/testsuite/gdb.base/load-command.exp
+++ b/gdb/testsuite/gdb.base/load-command.exp
@@ -20,7 +20,7 @@ standard_testfile
# Disable generation of position independent executable (PIE). Otherwise, we
# would have to manually specify an offset to load.
-set opts {debug ldflags=-no-pie}
+set opts {debug nopie}
if [prepare_for_testing "failed to prepare" $testfile $srcfile $opts] {
return -1
diff --git a/gdb/testsuite/gdb.dwarf2/fission-loclists-pie.exp b/gdb/testsuite/gdb.dwarf2/fission-loclists-pie.exp
index 773e200..2105356 100644
--- a/gdb/testsuite/gdb.dwarf2/fission-loclists-pie.exp
+++ b/gdb/testsuite/gdb.dwarf2/fission-loclists-pie.exp
@@ -40,7 +40,7 @@ standard_testfile .S
set obj [standard_output_file "${testfile}.o"]
set dwo [standard_output_file "${testfile}.dwo"]
if [build_executable_and_dwo_files "$testfile.exp" "${binfile}" \
- {nodebug ldflags=-pie} \
+ {nodebug pie} \
[list $srcfile [list nodebug split-dwo additional_flags=-DDWO=\"$dwo\"] \
$obj]] {
return -1