diff options
| author | Alexandra Hájková <ahajkova@redhat.com> | 2021-05-11 09:47:42 +0200 |
|---|---|---|
| committer | Alexandra Hájková <ahajkova@redhat.com> | 2021-05-19 10:05:19 +0200 |
| commit | b534617fd56d260d8d6c6c40124390ce72af476a (patch) | |
| tree | 769bb0b91f834cf5f8f9dcf4851ca389b989243c | |
| parent | 1b3892bedc7674dfd86b1b0285951271cd82de63 (diff) | |
| download | fsf-binutils-gdb-b534617fd56d260d8d6c6c40124390ce72af476a.zip fsf-binutils-gdb-b534617fd56d260d8d6c6c40124390ce72af476a.tar.gz fsf-binutils-gdb-b534617fd56d260d8d6c6c40124390ce72af476a.tar.bz2 | |
inflow.c: Do not leak tty.
In a case open() returns 0 tty might be leaked. While 0 should be
stdin (and therefore is an unlikely return value from open()), it's
still the case that the test should be for non-negative return values
from open().
gdb/ChangeLog:
2021-05-11 Alexandra Hájková <ahajkova@redhat.com>
* inflow.c (new_tty): Do not leak tty.
| -rw-r--r-- | gdb/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/inflow.c | 2 |
2 files changed, 6 insertions, 1 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 82131c1..4cc0cb8 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -247,6 +247,11 @@ * btrace.c (handle_pt_insn_events): Ignore status update enable events. +2021-05-11 Alexandra Hájková <ahajkova@redhat.com> + + * inflow.c (new_tty): Do not leak tty. + + 2021-05-11 Simon Marchi <simon.marchi@polymtl.ca> * arm-tdep.c (arm_record_data_proc_misc_ld_str): Fix diff --git a/gdb/inflow.c b/gdb/inflow.c index 994c73e..d241540 100644 --- a/gdb/inflow.c +++ b/gdb/inflow.c @@ -808,7 +808,7 @@ new_tty (void) systems (SVR4 for example), this may cause a SIGTTOU, so temporarily ignore SIGTTOU. */ tty = open ("/dev/tty", O_RDWR); - if (tty > 0) + if (tty >= 0) { scoped_ignore_sigttou ignore_sigttou; |