diff options
author | Andrew Burgess <aburgess@redhat.com> | 2023-05-17 09:50:12 +0100 |
---|---|---|
committer | Andrew Burgess <aburgess@redhat.com> | 2023-05-19 10:15:01 +0100 |
commit | a500c3d8e0260a556d48c7d5ee2bc4212982dfe2 (patch) | |
tree | bb5a9cb73fba071d17115ffc4ea5c3a5ae9a0e27 | |
parent | 637969a709c4542702d283a0471c5364d26ba81b (diff) | |
download | fsf-binutils-gdb-a500c3d8e0260a556d48c7d5ee2bc4212982dfe2.zip fsf-binutils-gdb-a500c3d8e0260a556d48c7d5ee2bc4212982dfe2.tar.gz fsf-binutils-gdb-a500c3d8e0260a556d48c7d5ee2bc4212982dfe2.tar.bz2 |
gdb/breakpoint: use warning function instead of gdb_printf
Noticed that in breakpoint.c, in one place, we do this:
gdb_printf (_("warning: Error removing "
"breakpoint %d\n"),
old_loc->owner->number);
Instead of using the `warning` function. There are a number of
differences between using gdb_printf like this and calling `warning`,
the main one is probably that real warnings are sent to gdb_stderr,
while the above gdb_printf call will go to gdb_stdout.
In this commit I:
1. Change to call `warning`, we can drop the "warning: " prefix from
the string in breakpoint.c,
2. Update the warning text, I now start with a lower case 'e', which
I believe is the GDB style for warnings,
3. And I have included the address of the bp_location in the warning
messsage,
4. Finally, I update all the tests (2) that include this error
message.
Reviewed-By: Tom Tromey <tom@tromey.com>
-rw-r--r-- | gdb/breakpoint.c | 6 | ||||
-rw-r--r-- | gdb/testsuite/gdb.base/break-main-file-remove-fail.exp | 4 | ||||
-rw-r--r-- | gdb/testsuite/gdb.base/hw-sw-break-same-address.exp | 2 |
3 files changed, 6 insertions, 6 deletions
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index fdb184a..552b789 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -11342,9 +11342,9 @@ update_global_location_list (enum ugll_insert_mode insert_mode) Note that at this point, old_loc->owner is still valid, as delete_breakpoint frees the breakpoint only after calling us. */ - gdb_printf (_("warning: Error removing " - "breakpoint %d\n"), - old_loc->owner->number); + warning (_("error removing breakpoint %d at %s"), + old_loc->owner->number, + paddress (old_loc->gdbarch, old_loc->address)); } removed = true; } diff --git a/gdb/testsuite/gdb.base/break-main-file-remove-fail.exp b/gdb/testsuite/gdb.base/break-main-file-remove-fail.exp index c7cf4f3..5e689fa 100644 --- a/gdb/testsuite/gdb.base/break-main-file-remove-fail.exp +++ b/gdb/testsuite/gdb.base/break-main-file-remove-fail.exp @@ -100,7 +100,7 @@ proc test_remove_bp { initial_load } { # get_integer_valueof. set munmap -1 gdb_test_multiple "print /d ${munmap_expr}" "get result of munmap call" { - -re -wrap "^(?:warning: Error removing breakpoint $::decimal\r\n)?\\$\[0-9\]* = (\[-\]*\[0-9\]*).*" { + -re -wrap "^(?:warning: error removing breakpoint $::decimal at $::hex\r\n)?\\$\[0-9\]* = (\[-\]*\[0-9\]*).*" { set munmap $expect_out(1,string) pass $gdb_test_name } @@ -112,7 +112,7 @@ proc test_remove_bp { initial_load } { } gdb_test "delete \$bpnum" \ - "warning: Error removing breakpoint .*" \ + "^warning: error removing breakpoint $::decimal at $::hex" \ "failure to remove breakpoint warns" } } diff --git a/gdb/testsuite/gdb.base/hw-sw-break-same-address.exp b/gdb/testsuite/gdb.base/hw-sw-break-same-address.exp index 9f94118..6ac69e5 100644 --- a/gdb/testsuite/gdb.base/hw-sw-break-same-address.exp +++ b/gdb/testsuite/gdb.base/hw-sw-break-same-address.exp @@ -50,7 +50,7 @@ with_test_prefix "hw-sw" { # A bad GDB debugging against GDBserver would output a warning # here: # delete breakpoints - # warning: Error removing breakpoint 3 + # warning: error removing breakpoint 3 at <ADDRESS> # (gdb) FAIL: gdb.base/hw-sw-break-same-address.exp: hw-sw: delete breakpoints gdb_test_no_output "delete breakpoints" } |