aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Tromey <tom@tromey.com>2020-04-01 14:09:52 -0600
committerTom Tromey <tromey@adacore.com>2020-04-01 14:09:53 -0600
commit6b4a335bf7b7996e904e895b3fdc35443c40cfca (patch)
tree6f22d2f7099db83a424a6fa06bcc854998f90372
parent3638a098a21ce706ef2b17185f3b165e4f9a5c54 (diff)
downloadfsf-binutils-gdb-6b4a335bf7b7996e904e895b3fdc35443c40cfca.zip
fsf-binutils-gdb-6b4a335bf7b7996e904e895b3fdc35443c40cfca.tar.gz
fsf-binutils-gdb-6b4a335bf7b7996e904e895b3fdc35443c40cfca.tar.bz2
Fix value_literal_complex comment
Christian pointed out that the value_literal_complex was still a bit weird; this patch rewrites it and moves it to value.h. gdb/ChangeLog 2020-04-01 Tom Tromey <tom@tromey.com> * value.h (value_literal_complex): Add comment. * valops.c (value_literal_complex): Refer to value.h.
-rw-r--r--gdb/ChangeLog5
-rw-r--r--gdb/valops.c6
-rw-r--r--gdb/value.h4
3 files changed, 11 insertions, 4 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 61d3007..12f0995 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2020-04-01 Tom Tromey <tom@tromey.com>
+ * value.h (value_literal_complex): Add comment.
+ * valops.c (value_literal_complex): Refer to value.h.
+
+2020-04-01 Tom Tromey <tom@tromey.com>
+
* c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
(scalar_type): New rule, from typebase.
(typebase): Use scalar_type. Recognize complex types.
diff --git a/gdb/valops.c b/gdb/valops.c
index 83fd258..03c6482 100644
--- a/gdb/valops.c
+++ b/gdb/valops.c
@@ -3854,12 +3854,10 @@ value_slice (struct value *array, int lowbound, int length)
return slice;
}
-/* Create a value for a FORTRAN complex number. Currently most of the
- time values are coerced to COMPLEX*16 (i.e. a complex number
- composed of 2 doubles. */
+/* See value.h. */
struct value *
-value_literal_complex (struct value *arg1,
+value_literal_complex (struct value *arg1,
struct value *arg2,
struct type *type)
{
diff --git a/gdb/value.h b/gdb/value.h
index 85fe6c2..247be13 100644
--- a/gdb/value.h
+++ b/gdb/value.h
@@ -1138,6 +1138,10 @@ extern struct value *varying_to_slice (struct value *);
extern struct value *value_slice (struct value *, int, int);
+/* Create a complex number. The type is the complex type; the values
+ are cast to the underlying scalar type before the complex number is
+ created. */
+
extern struct value *value_literal_complex (struct value *, struct value *,
struct type *);