aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLulu Cai <cailulu@loongson.cn>2024-01-03 19:57:10 +0800
committerliuzhensong <liuzhensong@loongson.cn>2024-01-11 14:08:24 +0800
commit21455a847de4301fd6afaffaa2e168b0f58242d9 (patch)
tree67843a29f41d0f1979a71948191c9186ea1edab1
parent20617191e4813ac5dec0ca46931253f46b1719a3 (diff)
downloadfsf-binutils-gdb-21455a847de4301fd6afaffaa2e168b0f58242d9.zip
fsf-binutils-gdb-21455a847de4301fd6afaffaa2e168b0f58242d9.tar.gz
fsf-binutils-gdb-21455a847de4301fd6afaffaa2e168b0f58242d9.tar.bz2
LoongArch: Discard extra spaces in objdump output
Due to the formatted output of objdump, some instructions that do not require output operands (such as nop/ret) will have extra spaces added after them. Determine whether to output operands through the format of opcodes. When opc->format is an empty string, no extra spaces are output.
-rw-r--r--gas/testsuite/gas/loongarch/64_pcrel.d2
-rw-r--r--gas/testsuite/gas/loongarch/deprecated_reg_aliases.d2
-rw-r--r--gas/testsuite/gas/loongarch/jmp_op.d4
-rw-r--r--gas/testsuite/gas/loongarch/nop.d2
-rw-r--r--gas/testsuite/gas/loongarch/privilege_op.d14
-rw-r--r--gas/testsuite/gas/loongarch/reloc.d2
-rw-r--r--opcodes/loongarch-dis.c7
7 files changed, 19 insertions, 14 deletions
diff --git a/gas/testsuite/gas/loongarch/64_pcrel.d b/gas/testsuite/gas/loongarch/64_pcrel.d
index 66b80a3..642e307 100644
--- a/gas/testsuite/gas/loongarch/64_pcrel.d
+++ b/gas/testsuite/gas/loongarch/64_pcrel.d
@@ -7,5 +7,5 @@
Disassembly of section .text:
00000000.* <.text>:
-[ ]+0:[ ]+03400000[ ]+nop[ ]+
+[ ]+0:[ ]+03400000[ ]+nop
[ ]+0:[ ]+R_LARCH_64_PCREL[ ]+\*ABS\*
diff --git a/gas/testsuite/gas/loongarch/deprecated_reg_aliases.d b/gas/testsuite/gas/loongarch/deprecated_reg_aliases.d
index 3ea0806..01e593f 100644
--- a/gas/testsuite/gas/loongarch/deprecated_reg_aliases.d
+++ b/gas/testsuite/gas/loongarch/deprecated_reg_aliases.d
@@ -15,4 +15,4 @@ Disassembly of section .text:
[ ]+8:[ ]+16024685[ ]+lu32i\.d[ ]+\$a1, 4660
[ ]+c:[ ]+08200420[ ]+fmadd\.d[ ]+\$fa0, \$fa1, \$fa1, \$fa0
[ ]+10:[ ]+380c16a4[ ]+ldx\.d[ ]+\$a0, \$r21, \$a1
-[ ]+14:[ ]+4c000020[ ]+ret[ ]+
+[ ]+14:[ ]+4c000020[ ]+ret
diff --git a/gas/testsuite/gas/loongarch/jmp_op.d b/gas/testsuite/gas/loongarch/jmp_op.d
index cc544f1..2157607 100644
--- a/gas/testsuite/gas/loongarch/jmp_op.d
+++ b/gas/testsuite/gas/loongarch/jmp_op.d
@@ -7,7 +7,7 @@
Disassembly of section .text:
00000000.* <.L1>:
-[ ]+0:[ ]+03400000[ ]+nop[ ]+
+[ ]+0:[ ]+03400000[ ]+nop
[ ]+4:[ ]+63fffc04[ ]+bgtz[ ]+\$a0,[ ]+-4[ ]+#[ ]+0[ ]+<\.L1>
[ ]+4:[ ]+R_LARCH_B16[ ]+\.L1
[ ]+8:[ ]+67fff880[ ]+bgez[ ]+\$a0,[ ]+-8[ ]+#[ ]+0[ ]+<\.L1>
@@ -47,4 +47,4 @@ Disassembly of section .text:
[ ]+4c:[ ]+R_LARCH_B16[ ]+\.L1
[ ]+50:[ ]+6fffb0a4[ ]+bgeu[ ]+\$a1,[ ]+\$a0,[ ]+-80[ ]+#[ ]+0[ ]+<\.L1>
[ ]+50:[ ]+R_LARCH_B16[ ]+\.L1
-[ ]+54:[ ]+4c000020[ ]+ret[ ]+
+[ ]+54:[ ]+4c000020[ ]+ret
diff --git a/gas/testsuite/gas/loongarch/nop.d b/gas/testsuite/gas/loongarch/nop.d
index 222456e..ca8c563 100644
--- a/gas/testsuite/gas/loongarch/nop.d
+++ b/gas/testsuite/gas/loongarch/nop.d
@@ -7,4 +7,4 @@
Disassembly of section .text:
0+000 <target>:
-[ ]+0:[ ]+03400000[ ]+nop[ ]+
+[ ]+0:[ ]+03400000[ ]+nop
diff --git a/gas/testsuite/gas/loongarch/privilege_op.d b/gas/testsuite/gas/loongarch/privilege_op.d
index 73925f2..e9ca60b 100644
--- a/gas/testsuite/gas/loongarch/privilege_op.d
+++ b/gas/testsuite/gas/loongarch/privilege_op.d
@@ -31,13 +31,13 @@ Disassembly of section .text:
[ ]+54:[ ]+064814a4 [ ]+iocsrwr.h[ ]+[ ]+\$a0, \$a1
[ ]+58:[ ]+064818a4 [ ]+iocsrwr.w[ ]+[ ]+\$a0, \$a1
[ ]+5c:[ ]+06481ca4 [ ]+iocsrwr.d[ ]+[ ]+\$a0, \$a1
-[ ]+60:[ ]+06482000 [ ]+tlbclr[ ]+
-[ ]+64:[ ]+06482400 [ ]+tlbflush[ ]+
-[ ]+68:[ ]+06482800 [ ]+tlbsrch[ ]+
-[ ]+6c:[ ]+06482c00 [ ]+tlbrd[ ]+
-[ ]+70:[ ]+06483000 [ ]+tlbwr[ ]+
-[ ]+74:[ ]+06483400 [ ]+tlbfill[ ]+
-[ ]+78:[ ]+06483800 [ ]+ertn[ ]+
+[ ]+60:[ ]+06482000 [ ]+tlbclr
+[ ]+64:[ ]+06482400 [ ]+tlbflush
+[ ]+68:[ ]+06482800 [ ]+tlbsrch
+[ ]+6c:[ ]+06482c00 [ ]+tlbrd
+[ ]+70:[ ]+06483000 [ ]+tlbwr
+[ ]+74:[ ]+06483400 [ ]+tlbfill
+[ ]+78:[ ]+06483800 [ ]+ertn
[ ]+7c:[ ]+06488000 [ ]+idle[ ]+[ ]+0x0
[ ]+80:[ ]+0648ffff [ ]+idle[ ]+[ ]+0x7fff
[ ]+84:[ ]+064998a0 [ ]+invtlb[ ]+[ ]+0x0, \$a1, \$a2
diff --git a/gas/testsuite/gas/loongarch/reloc.d b/gas/testsuite/gas/loongarch/reloc.d
index 0458830..fa249c5 100644
--- a/gas/testsuite/gas/loongarch/reloc.d
+++ b/gas/testsuite/gas/loongarch/reloc.d
@@ -8,7 +8,7 @@
Disassembly of section .text:
00000000.* <.text>:
-[ ]+0:[ ]+03400000[ ]+nop[ ]+
+[ ]+0:[ ]+03400000[ ]+nop
[ ]+4:[ ]+58000085[ ]+beq[ ]+\$a0,[ ]+\$a1,[ ]+0[ ]+#[ ]+0x4
[ ]+4:[ ]+R_LARCH_B16[ ]+.L1
[ ]+8:[ ]+5c000085[ ]+bne[ ]+\$a0,[ ]+\$a1,[ ]+0[ ]+#[ ]+0x8
diff --git a/opcodes/loongarch-dis.c b/opcodes/loongarch-dis.c
index 66a5596..c0f0642 100644
--- a/opcodes/loongarch-dis.c
+++ b/opcodes/loongarch-dis.c
@@ -267,7 +267,12 @@ disassemble_one (insn_t insn, struct disassemble_info *info)
}
info->insn_type = dis_nonbranch;
- info->fprintf_styled_func (info->stream, dis_style_mnemonic, "%-12s", opc->name);
+ if (opc->format == NULL || opc->format[0] == '\0')
+ info->fprintf_styled_func (info->stream, dis_style_mnemonic,
+ "%s", opc->name);
+ else
+ info->fprintf_styled_func (info->stream, dis_style_mnemonic,
+ "%-12s", opc->name);
{
char *fake_args = xmalloc (strlen (opc->format) + 1);