diff options
| author | Simon Marchi <simon.marchi@ericsson.com> | 2018-10-04 22:43:27 -0400 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@ericsson.com> | 2018-10-04 22:59:44 -0400 |
| commit | 1f88d0c87c37d3a15fa6376335e8b0d1c79d85aa (patch) | |
| tree | 211de0a181fb8d8f6ea030ab839fd6bc8d9e0869 | |
| parent | 1f041c6edf49a896b99db253066fce427a7d2264 (diff) | |
| download | fsf-binutils-gdb-1f88d0c87c37d3a15fa6376335e8b0d1c79d85aa.zip fsf-binutils-gdb-1f88d0c87c37d3a15fa6376335e8b0d1c79d85aa.tar.gz fsf-binutils-gdb-1f88d0c87c37d3a15fa6376335e8b0d1c79d85aa.tar.bz2 | |
Fix undefined behavior, don't pass NULL to fwrite
If a vector that we try to write using file_write is empty, we may end
up passing NULL to fwrite, which triggers UBSan:
.../gdb/dwarf-index-write.c:73:14: runtime error: null pointer passed as argument 1, which is declared to never be null
Avoid it by skipping the write if the vector is empty.
gdb/ChangeLog:
* dwarf-index-write.c (file_write): Don't write if the vector is
empty.
| -rw-r--r-- | gdb/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/dwarf-index-write.c | 3 |
2 files changed, 7 insertions, 1 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 126deb7..0e5a3f4 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2018-10-04 Simon Marchi <simon.marchi@ericsson.com> + + * dwarf-index-write.c (file_write): Don't write if the vector is + empty. + 2018-10-05 Tom de Vries <tdevries@suse.de> * python/py-progspace.c (pspy_solib_name): Fix type mismatch in diff --git a/gdb/dwarf-index-write.c b/gdb/dwarf-index-write.c index 2520321..d4585af 100644 --- a/gdb/dwarf-index-write.c +++ b/gdb/dwarf-index-write.c @@ -80,7 +80,8 @@ template<typename Elem, typename Alloc> static void file_write (FILE *file, const std::vector<Elem, Alloc> &vec) { - file_write (file, vec.data (), vec.size () * sizeof (vec[0])); + if (!vec.empty ()) + file_write (file, vec.data (), vec.size () * sizeof (vec[0])); } /* In-memory buffer to prepare data to be written later to a file. */ |