diff options
| author | Alan Modra <amodra@gmail.com> | 2020-03-28 14:31:02 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2020-03-28 14:40:58 +1030 |
| commit | 0a6a8b596b285d5c3cdf086ca85be59ff0a97071 (patch) | |
| tree | ce1988a8c93729adcb44e73eccfce0244535880f | |
| parent | 6a81c59be7561dd36b35dafdd65e499f03977232 (diff) | |
| download | fsf-binutils-gdb-0a6a8b596b285d5c3cdf086ca85be59ff0a97071.zip fsf-binutils-gdb-0a6a8b596b285d5c3cdf086ca85be59ff0a97071.tar.gz fsf-binutils-gdb-0a6a8b596b285d5c3cdf086ca85be59ff0a97071.tar.bz2 | |
Re: Adjust objcopy_test
Last patch didn't manage to xfail spu due to clear_xfail *-*-*elf*.
Clearing *-*-*elf* dates back to a time when we had rather a lot more
setup_xfail patterns, so limiting it to hppa*-*-*elf*. Also,
mips-*-irix ought to have been mips-*-irix* and I'm having second
thoughts about xfailing mips and hiding what looks like a problem: If
the mips target is supposed to emit names for local section symbols
and does so for objcopy, why isn't it doing the same for ld? Also,
lots more mips targets would be subject to this test failing. So I'm
backing out those xfails and leaving it to someone more knowledgeable
about mips.
* testsuite/binutils-all/objcopy.exp (objcopy_test): Only
clear_xfail hppa*-*-*elf*. Revert mips xfails.
| -rw-r--r-- | binutils/ChangeLog | 5 | ||||
| -rw-r--r-- | binutils/testsuite/binutils-all/objcopy.exp | 8 |
2 files changed, 9 insertions, 4 deletions
diff --git a/binutils/ChangeLog b/binutils/ChangeLog index cb8836c..c7c2d73 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,5 +1,10 @@ 2020-03-28 Alan Modra <amodra@gmail.com> + * testsuite/binutils-all/objcopy.exp (objcopy_test): Only + clear_xfail hppa*-*-*elf*. Revert mips xfails. + +2020-03-28 Alan Modra <amodra@gmail.com> + * testsuite/binutils-all/objcopy.exp (objcopy_test): Move xfails from here to calls. Remove "m8*-*-*" entry. Don't xfail tic54x but do xfail spu, mipstx39 and mips-sgi-irix for the executable diff --git a/binutils/testsuite/binutils-all/objcopy.exp b/binutils/testsuite/binutils-all/objcopy.exp index 0eafcdb..e4eb53c 100644 --- a/binutils/testsuite/binutils-all/objcopy.exp +++ b/binutils/testsuite/binutils-all/objcopy.exp @@ -117,7 +117,7 @@ setup_xfail "hppa*-*-*" setup_xfail "sh-*-coff*" setup_xfail "tic54x-*-*" clear_xfail "hppa*64*-*-hpux*" "hppa*-*-linux*" "hppa*-*-lites*" -clear_xfail "hppa*-*-*n*bsd*" "hppa*-*-rtems*" "*-*-*elf*" +clear_xfail "hppa*-*-*n*bsd*" "hppa*-*-rtems*" "hppa*-*-*elf*" objcopy_test "simple copy" bintest.s object "" "" # Test verilog data width @@ -1112,7 +1112,7 @@ if [is_elf_format] { setup_xfail "sh-*-coff*" setup_xfail "tic54x-*-*" clear_xfail "hppa*64*-*-hpux*" "hppa*-*-linux*" "hppa*-*-lites*" - clear_xfail "hppa*-*-*n*bsd*" "hppa*-*-rtems*" "*-*-*elf*" + clear_xfail "hppa*-*-*n*bsd*" "hppa*-*-rtems*" "hppa*-*-*elf*" objcopy_test "ELF unknown section type" unknown.s object "" "" objcopy_test_readelf "ELF group 1" group.s @@ -1345,7 +1345,7 @@ run_dump_test "set-section-alignment" setup_xfail "hppa*-*-*" setup_xfail "sh-*-coff*" -setup_xfail "mips-*-irix" "mipstx39-*-*" "spu-*-*" +setup_xfail "spu-*-*" clear_xfail "hppa*64*-*-hpux*" "hppa*-*-linux*" "hppa*-*-lites*" -clear_xfail "hppa*-*-*n*bsd*" "hppa*-*-rtems*" "*-*-*elf*" +clear_xfail "hppa*-*-*n*bsd*" "hppa*-*-rtems*" "hppa*-*-*elf*" objcopy_test "pr25662" pr25662.s executable "" "-T$srcdir/$subdir/pr25662.ld" |