aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2023-06-23 08:48:38 +0930
committerAlan Modra <amodra@gmail.com>2023-06-23 21:06:41 +0930
commit7ad52a2357f1d6eb886f548bdb4dae7e15d5f827 (patch)
tree9ece543ec4665c5951418dc488abdb377b85dc86
parent9f6be18644299ae40cb3d2844d1d38797a112c3c (diff)
downloadfsf-binutils-gdb-7ad52a2357f1d6eb886f548bdb4dae7e15d5f827.zip
fsf-binutils-gdb-7ad52a2357f1d6eb886f548bdb4dae7e15d5f827.tar.gz
fsf-binutils-gdb-7ad52a2357f1d6eb886f548bdb4dae7e15d5f827.tar.bz2
[GOLD] powerpc DT_RELACOUNT
DT_RELACOUNT was calculated incorrectly, and relative relocs not sorted as they should be to the start of .rela.dyn, due to adding one particular class of dynamic reloc using the wrong "add" method. * powerpc.cc (Target_powerpc::Scan::global): Add relative dyn relocs for ADDR64 and similar using add_global_relative. (cherry picked from commit 027614abf11de9e79a335df4e1f9a788b7ab0063)
-rw-r--r--gold/powerpc.cc9
1 files changed, 7 insertions, 2 deletions
diff --git a/gold/powerpc.cc b/gold/powerpc.cc
index aa2d9a1..0c15e1b 100644
--- a/gold/powerpc.cc
+++ b/gold/powerpc.cc
@@ -9005,9 +9005,14 @@ Target_powerpc<size, big_endian>::Scan::global(
= target->rela_dyn_section(symtab, layout, is_ifunc);
unsigned int dynrel = (is_ifunc ? elfcpp::R_POWERPC_IRELATIVE
: elfcpp::R_POWERPC_RELATIVE);
- rela_dyn->add_symbolless_global_addend(
+ // Use the "add" method that marks the reloc as being
+ // relative. This is proper here and in other places
+ // that add IRELATIVE relocs because those relocs go
+ // into a separate section that isn't sorted, so it
+ // doesn't matter that they are marked is_relative.
+ rela_dyn->add_global_relative(
gsym, dynrel, output_section, object, data_shndx,
- reloc.get_r_offset(), reloc.get_r_addend());
+ reloc.get_r_offset(), reloc.get_r_addend(), false);
}
else
{