diff options
| author | H.J. Lu <hjl.tools@gmail.com> | 2016-02-24 15:13:35 -0800 |
|---|---|---|
| committer | H.J. Lu <hjl.tools@gmail.com> | 2016-02-24 15:13:48 -0800 |
| commit | 0f550b3df1d4ae31d12505cf93981313c9c6dd25 (patch) | |
| tree | 854ccf6e75c3ec01fe29f0594669c0c1d89b7d1e | |
| parent | e7ad2f145c05bc60b1cd2796c8f3b72f02e3e730 (diff) | |
| download | fsf-binutils-gdb-0f550b3df1d4ae31d12505cf93981313c9c6dd25.zip fsf-binutils-gdb-0f550b3df1d4ae31d12505cf93981313c9c6dd25.tar.gz fsf-binutils-gdb-0f550b3df1d4ae31d12505cf93981313c9c6dd25.tar.bz2 | |
Update symbol version for symbol from linker script
We need to update symbol version for symbols from linker script.
bfd/
PR ld/19698
* elflink.c (bfd_elf_record_link_assignment): Set versioned if
symbol version is unknown.
ld/
PR ld/19698
* testsuite/ld-elf/pr19698.d: New file.
* testsuite/ld-elf/pr19698.s: Likewise.
* testsuite/ld-elf/pr19698.t: Likewise.
| -rw-r--r-- | bfd/ChangeLog | 6 | ||||
| -rw-r--r-- | bfd/elflink.c | 13 | ||||
| -rw-r--r-- | ld/ChangeLog | 7 | ||||
| -rw-r--r-- | ld/testsuite/ld-elf/pr19698.d | 10 | ||||
| -rw-r--r-- | ld/testsuite/ld-elf/pr19698.s | 5 | ||||
| -rw-r--r-- | ld/testsuite/ld-elf/pr19698.t | 11 |
6 files changed, 52 insertions, 0 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index e48f76b..2a32a6f 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,5 +1,11 @@ 2016-02-24 H.J. Lu <hongjiu.lu@intel.com> + PR ld/19698 + * elflink.c (bfd_elf_record_link_assignment): Set versioned if + symbol version is unknown. + +2016-02-24 H.J. Lu <hongjiu.lu@intel.com> + * elf32-i386.c (elf_i386_allocate_dynrelocs): Set plt_got.offset to (bfd_vma) -1 when setting needs_plt to 0. * elf64-x86-64.c (elf_x86_64_allocate_dynrelocs): Likewise. diff --git a/bfd/elflink.c b/bfd/elflink.c index 7d565f5..993e9b9 100644 --- a/bfd/elflink.c +++ b/bfd/elflink.c @@ -555,6 +555,19 @@ bfd_elf_record_link_assignment (bfd *output_bfd, if (h == NULL) return provide; + if (h->versioned == unknown) + { + /* Set versioned if symbol version is unknown. */ + char *version = strrchr (name, ELF_VER_CHR); + if (version) + { + if (version > name && version[-1] != ELF_VER_CHR) + h->versioned = versioned_hidden; + else + h->versioned = versioned; + } + } + switch (h->root.type) { case bfd_link_hash_defined: diff --git a/ld/ChangeLog b/ld/ChangeLog index 7eacba8..73d3f9d 100644 --- a/ld/ChangeLog +++ b/ld/ChangeLog @@ -1,3 +1,10 @@ +2016-02-24 H.J. Lu <hongjiu.lu@intel.com> + + PR ld/19698 + * testsuite/ld-elf/pr19698.d: New file. + * testsuite/ld-elf/pr19698.s: Likewise. + * testsuite/ld-elf/pr19698.t: Likewise. + 2016-02-23 H.J. Lu <hongjiu.lu@intel.com> * Makefile.am (ELF_X86_DEPS): New. diff --git a/ld/testsuite/ld-elf/pr19698.d b/ld/testsuite/ld-elf/pr19698.d new file mode 100644 index 0000000..a39f67a --- /dev/null +++ b/ld/testsuite/ld-elf/pr19698.d @@ -0,0 +1,10 @@ +#ld: -shared $srcdir/$subdir/pr19698.t +#readelf : --dyn-syms --wide +#target: *-*-linux* *-*-gnu* *-*-solaris* + +Symbol table '\.dynsym' contains [0-9]+ entries: +#... + +[0-9]+: +[0-9a-f]+ +[0-9a-f]+ +FUNC +GLOBAL +DEFAULT +[0-9]+ +foo@VERS.1 +#... + +[0-9]+: +[0-9a-f]+ +[0-9a-f]+ +FUNC +GLOBAL +DEFAULT +[0-9]+ +foo@@VERS.2 +#pass diff --git a/ld/testsuite/ld-elf/pr19698.s b/ld/testsuite/ld-elf/pr19698.s new file mode 100644 index 0000000..875dca4 --- /dev/null +++ b/ld/testsuite/ld-elf/pr19698.s @@ -0,0 +1,5 @@ + .text + .globl foo + .type foo, %function +foo: + .byte 0 diff --git a/ld/testsuite/ld-elf/pr19698.t b/ld/testsuite/ld-elf/pr19698.t new file mode 100644 index 0000000..09d9125 --- /dev/null +++ b/ld/testsuite/ld-elf/pr19698.t @@ -0,0 +1,11 @@ +"foo@VERS.1" = foo; + +VERSION { +VERS.2 { + global: + foo; +}; + +VERS.1 { +}; +} |