Commit ef72ed42 authored by Paul Cercueil's avatar Paul Cercueil Committed by Lee Jones
Browse files

mfd: max77686: Remove #ifdef guards for PM related functions 



Use the new DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() macros
to handle the .suspend/.resume callbacks.

These macros allow the suspend and resume functions to be automatically
dropped by the compiler when CONFIG_SUSPEND is disabled, without having
to use #ifdef guards.

This has the advantage of always compiling these functions in,
independently of any Kconfig option. Thanks to that, bugs and other
regressions are subsequently easier to catch.

Signed-off-by: default avatarPaul Cercueil <paul@crapouillou.net>
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent 8a8d0485

drivers/mfd/max77686.c

+2 −4
Original line number Diff line number Diff line
@@ -226,7 +226,6 @@ static int max77686_i2c_probe(struct i2c_client *i2c) 
	return 0;

}



#ifdef CONFIG_PM_SLEEP

static int max77686_suspend(struct device *dev)

{

	struct i2c_client *i2c = to_i2c_client(dev);
@@ -261,14 +260,13 @@ static int max77686_resume(struct device *dev) 


	return 0;

}

#endif /* CONFIG_PM_SLEEP */



static SIMPLE_DEV_PM_OPS(max77686_pm, max77686_suspend, max77686_resume);

static DEFINE_SIMPLE_DEV_PM_OPS(max77686_pm, max77686_suspend, max77686_resume);



static struct i2c_driver max77686_i2c_driver = {

	.driver = {

		   .name = "max77686",

		   .pm = &max77686_pm,

		   .pm = pm_sleep_ptr(&max77686_pm),

		   .of_match_table = max77686_pmic_dt_match,

	},

	.probe_new = max77686_i2c_probe,