Commit ec83d6e5 authored by Pawel Laszczak's avatar Pawel Laszczak Committed by Greg Kroah-Hartman
Browse files

usb: cdnsp: Fix incorrect calling of cdnsp_died function 



commit 16f00d96 upstream.

Patch restrict calling of cdnsp_died function during removing modules
or software disconnect.
This function was called because after transition controller to HALT
state the driver starts handling the deferred interrupt.
In this case such interrupt can be simple ignored.

Fixes: 3d829045 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver")
cc: <stable@vger.kernel.org>
Reviewed-by: default avatarPeter Chen <peter.chen@kernel.org>
Signed-off-by: default avatarPawel Laszczak <pawell@cadence.com>
Link: https://lore.kernel.org/r/20211210112945.660-1-pawell@gli-login.cadence.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ed89521e

drivers/usb/cdns3/cdnsp-ring.c

+8 −1
Original line number Diff line number Diff line
@@ -1525,7 +1525,14 @@ irqreturn_t cdnsp_thread_irq_handler(int irq, void *data) 
	spin_lock_irqsave(&pdev->lock, flags);



	if (pdev->cdnsp_state & (CDNSP_STATE_HALTED | CDNSP_STATE_DYING)) {

		/*

		 * While removing or stopping driver there may still be deferred

		 * not handled interrupt which should not be treated as error.

		 * Driver should simply ignore it.

		 */

		if (pdev->gadget_driver)

			cdnsp_died(pdev);



		spin_unlock_irqrestore(&pdev->lock, flags);

		return IRQ_HANDLED;

	}