Commit eb9792a4 authored by Benoit Parrot's avatar Benoit Parrot Committed by Mauro Carvalho Chehab
Browse files

media: ti-vpe: cal: Fix a WARN issued when start streaming fails 



When start_streaming fails after the buffers have been queued we have to
make sure all buffers are returned to user-space properly otherwise a
v4l2 level WARN is generated.

Signed-off-by: default avatarBenoit Parrot <bparrot@ti.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 348d32d3

drivers/media/platform/ti-vpe/cal.c

+5 −0
Original line number Diff line number Diff line
@@ -1695,10 +1695,15 @@ static int cal_start_streaming(struct vb2_queue *vq, unsigned int count) 
	return 0;



err:

	spin_lock_irqsave(&ctx->slock, flags);

	vb2_buffer_done(&ctx->cur_frm->vb.vb2_buf, VB2_BUF_STATE_QUEUED);

	ctx->cur_frm = NULL;

	ctx->next_frm = NULL;

	list_for_each_entry_safe(buf, tmp, &dma_q->active, list) {

		list_del(&buf->list);

		vb2_buffer_done(&buf->vb.vb2_buf, VB2_BUF_STATE_QUEUED);

	}

	spin_unlock_irqrestore(&ctx->slock, flags);

	return ret;

}