Commit eb633de6 authored by Yang Yingliang's avatar Yang Yingliang Committed by Alexandre Belloni
Browse files

rtc: s3c: Switch to use dev_err_probe() helper 



In the probe path, dev_err() can be replace with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name.

Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20220919083812.755082-1-yangyingliang@huawei.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 5dc83568

drivers/rtc/rtc-s3c.c

+3 −8
Original line number Diff line number Diff line
@@ -429,14 +429,9 @@ static int s3c_rtc_probe(struct platform_device *pdev) 
		return PTR_ERR(info->base);



	info->rtc_clk = devm_clk_get(&pdev->dev, "rtc");

	if (IS_ERR(info->rtc_clk)) {

		ret = PTR_ERR(info->rtc_clk);

		if (ret != -EPROBE_DEFER)

			dev_err(&pdev->dev, "failed to find rtc clock\n");

		else

			dev_dbg(&pdev->dev, "probe deferred due to missing rtc clk\n");

		return ret;

	}

	if (IS_ERR(info->rtc_clk))

		return dev_err_probe(&pdev->dev, PTR_ERR(info->rtc_clk),

				     "failed to find rtc clock\n");

	ret = clk_prepare_enable(info->rtc_clk);

	if (ret)

		return ret;