Commit e87138e0 authored by Colin Ian King's avatar Colin Ian King Committed by Patrik Jakobsson
Browse files

drm/gma500/oaktrail_lvds: replace continue with break 



Currently a loop scans through the connector list checking
for connectors that do not match a specific criteria. The
use of the continue statement is a little unintuitive and
can confuse static analysis checking.  Invert the criteria
matching logic and use a break to terminate the loop once
the first suitable connector has been found.

Thanks to Patrik Jakobsson for explaining the original
intent of the code and suggesting this change.

Addresses-Coverity: ("Continue has no effect")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarPatrik Jakobsson <patrik.r.jakobsson@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210618183524.590186-1-colin.king@canonical.com
parent 12fc23a4

drivers/gpu/drm/gma500/oaktrail_lvds.c

+2 −2
Original line number Diff line number Diff line
@@ -113,8 +113,8 @@ static void oaktrail_lvds_mode_set(struct drm_encoder *encoder, 


	/* Find the connector we're trying to set up */

	list_for_each_entry(connector, &mode_config->connector_list, head) {

		if (!connector->encoder || connector->encoder->crtc != crtc)

			continue;

		if (connector->encoder && connector->encoder->crtc == crtc)

			break;

	}



	if (!connector) {