Commit da68a9f4 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Thierry Reding
Browse files

pwm: lpc32xx: Simplify using devm_pwmchip_add() 



This allows to drop the platform_driver's remove function. This is the
only user of driver data so this can go away, too.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent 071beb7c

drivers/pwm/pwm-lpc32xx.c

+1 −11
Original line number Diff line number Diff line
@@ -122,24 +122,15 @@ static int lpc32xx_pwm_probe(struct platform_device *pdev) 
	val &= ~PWM_PIN_LEVEL;

	writel(val, lpc32xx->base + (lpc32xx->chip.pwms[0].hwpwm << 2));



	ret = pwmchip_add(&lpc32xx->chip);

	ret = devm_pwmchip_add(&pdev->dev, &lpc32xx->chip);

	if (ret < 0) {

		dev_err(&pdev->dev, "failed to add PWM chip, error %d\n", ret);

		return ret;

	}



	platform_set_drvdata(pdev, lpc32xx);



	return 0;

}



static int lpc32xx_pwm_remove(struct platform_device *pdev)

{

	struct lpc32xx_pwm_chip *lpc32xx = platform_get_drvdata(pdev);



	return pwmchip_remove(&lpc32xx->chip);

}



static const struct of_device_id lpc32xx_pwm_dt_ids[] = {

	{ .compatible = "nxp,lpc3220-pwm", },

	{ /* sentinel */ }
@@ -152,7 +143,6 @@ static struct platform_driver lpc32xx_pwm_driver = { 
		.of_match_table = lpc32xx_pwm_dt_ids,

	},

	.probe = lpc32xx_pwm_probe,

	.remove = lpc32xx_pwm_remove,

};

module_platform_driver(lpc32xx_pwm_driver);