Commit d07bb970 authored Apr 23, 2021 by Mauro Carvalho Chehab

media: mdk-mdp: fix pm_runtime_get_sync() usage count



The pm_runtime_get_sync() internally increments the
dev->power.usage_count without decrementing it, even on errors.
Replace it by the new pm_runtime_resume_and_get(), introduced by:
commit dd8088d5 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
in order to properly decrement the usage counter, avoiding
a potential PM usage counter leak.

While here, fix the return contition of mtk_mdp_m2m_start_streaming(),
as it doesn't make any sense to return 0 if the PM runtime failed
to resume.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

parent e7c617ca

drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -391,12 +391,12 @@ static int mtk_mdp_m2m_start_streaming(struct vb2_queue *q, unsigned int count)
		struct mtk_mdp_ctx *ctx = q->drv_priv;
		int ret;

		ret = pm_runtime_get_sync(&ctx->mdp_dev->pdev->dev);
		ret = pm_runtime_resume_and_get(&ctx->mdp_dev->pdev->dev);
		if (ret < 0)
		mtk_mdp_dbg(1, "[%d] pm_runtime_get_sync failed:%d",
		mtk_mdp_dbg(1, "[%d] pm_runtime_resume_and_get failed:%d",
		ctx->id, ret);

		return 0;
		return ret;
		}

		static void mtk_mdp_m2m_buf_remove(struct mtk_mdp_ctx ctx,