Commit ab53749c authored by Abdun Nihaal's avatar Abdun Nihaal Committed by Greg Kroah-Hartman
Browse files

fs/ntfs3: Fix slab-out-of-bounds read in ntfs_trim_fs 

[ Upstream commit 557d1967 ]

Syzbot reports an out of bound access in ntfs_trim_fs.
The cause of this is using a loop termination condition that compares
window index (iw) with wnd->nbits instead of wnd->nwnd, due to which the
index used for wnd->free_bits exceeds the size of the array allocated.

Fix the loop condition.

Fixes: 3f3b442b ("fs/ntfs3: Add bitmap")
Link: https://syzkaller.appspot.com/bug?extid=b892240eac461e488d51


Reported-by: default avatar <syzbot+b892240eac461e488d51@syzkaller.appspotmail.com>
Signed-off-by: default avatarAbdun Nihaal <abdun.nihaal@gmail.com>
Signed-off-by: default avatarKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 1ba0968b

fs/ntfs3/bitmap.c

+1 −1
Original line number Diff line number Diff line
@@ -1432,7 +1432,7 @@ int ntfs_trim_fs(struct ntfs_sb_info *sbi, struct fstrim_range *range) 


	down_read_nested(&wnd->rw_lock, BITMAP_MUTEX_CLUSTERS);



	for (; iw < wnd->nbits; iw++, wbit = 0) {

	for (; iw < wnd->nwnd; iw++, wbit = 0) {

		CLST lcn_wnd = iw * wbits;

		struct buffer_head *bh;