Commit 9a842a7e authored by Alexandre Belloni's avatar Alexandre Belloni
Browse files

rtc: xgene: stop caching alarm_time 



There is no point in caching alarm_time for .read_alarm because
.read_alarm is only called at boo time and thus alarm_time is always 0.

Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent db785341

drivers/rtc/rtc-xgene.c

+3 −4
Original line number Diff line number Diff line
@@ -35,7 +35,6 @@ 
struct xgene_rtc_dev {

	struct rtc_device *rtc;

	struct device *dev;

	unsigned long alarm_time;

	void __iomem *csr_base;

	struct clk *clk;

	unsigned int irq_wake;
@@ -68,7 +67,8 @@ static int xgene_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm) 
{

	struct xgene_rtc_dev *pdata = dev_get_drvdata(dev);



	rtc_time_to_tm(pdata->alarm_time, &alrm->time);

	/* If possible, CMR should be read here */

	rtc_time_to_tm(0, &alrm->time);

	alrm->enabled = readl(pdata->csr_base + RTC_CCR) & RTC_CCR_IE;



	return 0;
@@ -105,8 +105,7 @@ static int xgene_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm) 
	unsigned long alarm_time;



	rtc_tm_to_time(&alrm->time, &alarm_time);

	pdata->alarm_time = alarm_time;

	writel((u32)pdata->alarm_time, pdata->csr_base + RTC_CMR);

	writel((u32)alarm_time, pdata->csr_base + RTC_CMR);



	xgene_rtc_alarm_irq_enable(dev, alrm->enabled);