Commit 606c54ae authored by Igor Pylypiv's avatar Igor Pylypiv Committed by Martin K. Petersen
Browse files

scsi: pm80xx: Update WARN_ON check in pm8001_mpi_build_cmd() 

Starting from commit 05c6c029 ("scsi: pm80xx: Increase number of
supported queues") driver initializes only max_q_num queues.  Do not use an
invalid queue if the WARN_ON condition is true.

Link: https://lore.kernel.org/r/20211101232825.2350233-4-ipylypiv@google.com


Fixes: 7640e1eb ("scsi: pm80xx: Make mpi_build_cmd locking consistent")
Reviewed-by: default avatarVishakha Channapattan <vishakhavc@google.com>
Acked-by: default avatarJack Wang <jinpu.wang@ionos.com>
Signed-off-by: default avatarIgor Pylypiv <ipylypiv@google.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 60de1a67

drivers/scsi/pm8001/pm8001_hwi.c

+3 −1
Original line number Diff line number Diff line
@@ -1325,7 +1325,9 @@ int pm8001_mpi_build_cmd(struct pm8001_hba_info *pm8001_ha, 
	int q_index = circularQ - pm8001_ha->inbnd_q_tbl;

	int rv;



	WARN_ON(q_index >= PM8001_MAX_INB_NUM);

	if (WARN_ON(q_index >= pm8001_ha->max_q_num))

		return -EINVAL;



	spin_lock_irqsave(&circularQ->iq_lock, flags);

	rv = pm8001_mpi_msg_free_get(circularQ, pm8001_ha->iomb_size,

			&pMessage);