Commit fee4ac32 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Jonathan Cameron
Browse files

iio: dac: ltc2688: Use temporary variable for struct device 



Use temporary variable for struct device to make code neater.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarNuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20220302153142.52743-1-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 8a7449d6

drivers/iio/dac/ltc2688.c

+9 −10
Original line number Diff line number Diff line
@@ -703,21 +703,20 @@ static int ltc2688_tgp_clk_setup(struct ltc2688_state *st, 
				 struct ltc2688_chan *chan,

				 struct fwnode_handle *node, int tgp)

{

	struct device *dev = &st->spi->dev;

	unsigned long rate;

	struct clk *clk;

	int ret, f;



	clk = devm_get_clk_from_child(&st->spi->dev, to_of_node(node), NULL);

	clk = devm_get_clk_from_child(dev, to_of_node(node), NULL);

	if (IS_ERR(clk))

		return dev_err_probe(&st->spi->dev, PTR_ERR(clk),

				     "failed to get tgp clk.\n");

		return dev_err_probe(dev, PTR_ERR(clk), "failed to get tgp clk.\n");



	ret = clk_prepare_enable(clk);

	if (ret)

		return dev_err_probe(&st->spi->dev, ret,

				     "failed to enable tgp clk.\n");

		return dev_err_probe(dev, ret, "failed to enable tgp clk.\n");



	ret = devm_add_action_or_reset(&st->spi->dev, ltc2688_clk_disable, clk);

	ret = devm_add_action_or_reset(dev, ltc2688_clk_disable, clk);

	if (ret)

		return ret;
@@ -858,6 +857,7 @@ static int ltc2688_channel_config(struct ltc2688_state *st) 


static int ltc2688_setup(struct ltc2688_state *st, struct regulator *vref)

{

	struct device *dev = &st->spi->dev;

	struct gpio_desc *gpio;

	int ret;
@@ -865,10 +865,9 @@ static int ltc2688_setup(struct ltc2688_state *st, struct regulator *vref) 
	 * If we have a reset pin, use that to reset the board, If not, use

	 * the reset bit.

	 */

	gpio = devm_gpiod_get_optional(&st->spi->dev, "clr", GPIOD_OUT_HIGH);

	gpio = devm_gpiod_get_optional(dev, "clr", GPIOD_OUT_HIGH);

	if (IS_ERR(gpio))

		return dev_err_probe(&st->spi->dev, PTR_ERR(gpio),

				     "Failed to get reset gpio");

		return dev_err_probe(dev, PTR_ERR(gpio), "Failed to get reset gpio");

	if (gpio) {

		usleep_range(1000, 1200);

		/* bring device out of reset */
@@ -887,7 +886,7 @@ static int ltc2688_setup(struct ltc2688_state *st, struct regulator *vref) 
	 * Duplicate the default channel configuration as it can change during

	 * @ltc2688_channel_config()

	 */

	st->iio_chan = devm_kmemdup(&st->spi->dev, ltc2688_channels,

	st->iio_chan = devm_kmemdup(dev, ltc2688_channels,

				    sizeof(ltc2688_channels), GFP_KERNEL);

	if (!st->iio_chan)

		return -ENOMEM;