Commit f27b1b2a authored by Tang Bin's avatar Tang Bin Committed by Jonathan Cameron
Browse files

iio: adc: fsl-imx25-gcq: adjust irq check to match docs and simplify code 



For the function of platform_get_irq(), the example in platform.c is
 *	int irq = platform_get_irq(pdev, 0);
 *	if (irq < 0)
 *		return irq;
the return value of zero is unnecessary to check, so make the right
check and simplify code.

Note that platform_get_irq() is documented as never returning 0
so this is a minor optmization rather than a fix.

Co-developed-by: default avatarZhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: default avatarZhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: default avatarTang Bin <tangbin@cmss.chinamobile.com>
Link: https://lore.kernel.org/r/20210802120929.33760-1-tangbin@cmss.chinamobile.com


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 6a25893c

drivers/iio/adc/fsl-imx25-gcq.c

+3 −6
Original line number Diff line number Diff line
@@ -347,14 +347,11 @@ static int mx25_gcq_probe(struct platform_device *pdev) 
		goto err_vref_disable;

	}



	priv->irq = platform_get_irq(pdev, 0);

	if (priv->irq <= 0) {

		ret = priv->irq;

		if (!ret)

			ret = -ENXIO;

	ret = platform_get_irq(pdev, 0);

	if (ret < 0)

		goto err_clk_unprepare;

	}



	priv->irq = ret;

	ret = request_irq(priv->irq, mx25_gcq_irq, 0, pdev->name, priv);

	if (ret) {

		dev_err(dev, "Failed requesting IRQ\n");