Commit ecdb69e2 authored by Sachin Prabhu's avatar Sachin Prabhu Committed by Steve French
Browse files

cifs: Mangle string used for unc in /proc/mounts 



The string for "unc=" in /proc/mounts needs to be escaped. The current
behaviour can create problems in cases when mounting a share starting
with a number.

example:
>mount -t cifs -o username=test,password=x vm140-31:/17000-test /mnt
>mount -o remount,password=x /mnt
mount error: could not resolve address for vm140-31x00-test: Unknown
error

The sub-string "\170" which is part of the unc for the mount above in
/proc/mounts is interpreted as character'x' in the case above. Escaping
the string fixes the problem.

Signed-off-by: default avatarSachin Prabhu <sprabhu@redhat.com>
Reviewed-by: default avatarJeff Layton <jlayton@redhat.com>
Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
parent 101b92d9

fs/cifs/cifsfs.c

+2 −1
Original line number Diff line number Diff line
@@ -350,7 +350,8 @@ cifs_show_options(struct seq_file *s, struct dentry *root) 
	cifs_show_security(s, tcon->ses->server);

	cifs_show_cache_flavor(s, cifs_sb);



	seq_printf(s, ",unc=%s", tcon->treeName);

	seq_printf(s, ",unc=");

	seq_escape(s, tcon->treeName, " \t\n\\");



	if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MULTIUSER)

		seq_printf(s, ",multiuser");