Commit ead5a727 authored by Alexey Dobriyan's avatar Alexey Dobriyan Committed by Andrew Morton
Browse files

proc: save LOC by using while loop 

Use while loop instead of infinite loop with "break;".

Also move some variable to the inner scope where they belong.

Link: https://lkml.kernel.org/r/82c8f8e7-8ded-46ca-8857-e60b991d6205@p183


Signed-off-by: default avatarAlexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 860a2e7f

fs/proc/inode.c

+4 −7
Original line number Diff line number Diff line
@@ -110,18 +110,15 @@ void __init proc_init_kmemcache(void) 


void proc_invalidate_siblings_dcache(struct hlist_head *inodes, spinlock_t *lock)

{

	struct inode *inode;

	struct proc_inode *ei;

	struct hlist_node *node;

	struct super_block *old_sb = NULL;



	rcu_read_lock();

	for (;;) {

	while ((node = hlist_first_rcu(inodes))) {

		struct proc_inode *ei = hlist_entry(node, struct proc_inode, sibling_inodes);

		struct super_block *sb;

		node = hlist_first_rcu(inodes);

		if (!node)

			break;

		ei = hlist_entry(node, struct proc_inode, sibling_inodes);

		struct inode *inode;



		spin_lock(lock);

		hlist_del_init_rcu(&ei->sibling_inodes);

		spin_unlock(lock);