Commit e1efbc8e authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Lee Jones
Browse files

mfd: intel_soc_pmic_crc: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() etc 



Letting the compiler remove these functions when the kernel is built
without CONFIG_PM_SLEEP support is simpler and less error prone than the
use of #ifdef based kernel configuration guards.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20220801114211.36267-6-andriy.shevchenko@linux.intel.com
parent 4b74ec58

drivers/mfd/intel_soc_pmic_crc.c

+2 −5
Original line number Diff line number Diff line
@@ -234,7 +234,6 @@ static void intel_soc_pmic_shutdown(struct i2c_client *i2c) 
	return;

}



#if defined(CONFIG_PM_SLEEP)

static int intel_soc_pmic_suspend(struct device *dev)

{

	struct intel_soc_pmic *pmic = dev_get_drvdata(dev);
@@ -252,10 +251,8 @@ static int intel_soc_pmic_resume(struct device *dev) 


	return 0;

}

#endif



static SIMPLE_DEV_PM_OPS(intel_soc_pmic_pm_ops, intel_soc_pmic_suspend,

			 intel_soc_pmic_resume);

static DEFINE_SIMPLE_DEV_PM_OPS(crystal_cove_pm_ops, intel_soc_pmic_suspend, intel_soc_pmic_resume);



static const struct i2c_device_id intel_soc_pmic_i2c_id[] = {

	{ }
@@ -273,7 +270,7 @@ MODULE_DEVICE_TABLE(acpi, intel_soc_pmic_acpi_match); 
static struct i2c_driver intel_soc_pmic_i2c_driver = {

	.driver = {

		.name = "intel_soc_pmic_i2c",

		.pm = &intel_soc_pmic_pm_ops,

		.pm = pm_sleep_ptr(&crystal_cove_pm_ops),

		.acpi_match_table = ACPI_PTR(intel_soc_pmic_acpi_match),

	},

	.probe = intel_soc_pmic_i2c_probe,