Commit cdaaff61 authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: ufs: core: Remove request tag range checks 



The block layer core guarantees that tag numbers are in the expected
range. Hence remove the statements that check this. This patch suppresses
Coverity warnings about left shifts with a negative right hand operand.
The following commit originally introduced request tag range checks:
14497328 ("scsi: ufs: verify command tag validity").

Cc: daejun7.park@samsung.com
Cc: John Garry <john.g.garry@oracle.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230921192335.676924-2-bvanassche@acm.org


Reviewed-by: default avatarJohn Garry <john.g.garry@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 0bb80ecc

drivers/ufs/core/ufshcd.c

+0 −6
Original line number Diff line number Diff line
@@ -2822,8 +2822,6 @@ static int ufshcd_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd) 
	int err = 0;

	struct ufs_hw_queue *hwq = NULL;



	WARN_ONCE(tag < 0 || tag >= hba->nutrs, "Invalid tag %d\n", tag);



	switch (hba->ufshcd_state) {

	case UFSHCD_STATE_OPERATIONAL:

		break;
@@ -6923,8 +6921,6 @@ static int __ufshcd_issue_tm_cmd(struct ufs_hba *hba, 
	spin_lock_irqsave(host->host_lock, flags);



	task_tag = req->tag;

	WARN_ONCE(task_tag < 0 || task_tag >= hba->nutmrs, "Invalid tag %d\n",

		  task_tag);

	hba->tmf_rqs[req->tag] = req;

	treq->upiu_req.req_header.task_tag = task_tag;
@@ -7498,8 +7494,6 @@ static int ufshcd_abort(struct scsi_cmnd *cmd) 
	bool outstanding;

	u32 reg;



	WARN_ONCE(tag < 0, "Invalid tag %d\n", tag);



	ufshcd_hold(hba);



	if (!is_mcq_enabled(hba)) {