Commit cda915c9 authored by Martin Kaiser's avatar Martin Kaiser Committed by Greg Kroah-Hartman
Browse files

staging: rtl8188eu: make rtw_free_recvframe return void 



None of the callers checks the return value of rtw_free_recvframe.

Signed-off-by: default avatarMartin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20210605165858.3175-4-martin@kaiser.cx


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d3f3fb98

drivers/staging/rtl8188eu/core/rtw_recv.c

+3 −5
Original line number Diff line number Diff line
@@ -114,11 +114,11 @@ struct recv_frame *rtw_alloc_recvframe(struct __queue *pfree_recv_queue) 
	return precvframe;

}



int rtw_free_recvframe(struct recv_frame *precvframe,

		       struct __queue *pfree_recv_queue)

void rtw_free_recvframe(struct recv_frame *precvframe, struct __queue *pfree_recv_queue)

{

	if (!precvframe)

		return _FAIL;

		return;



	if (precvframe->pkt) {

		dev_kfree_skb_any(precvframe->pkt);/* free skb by driver */

		precvframe->pkt = NULL;
@@ -131,8 +131,6 @@ int rtw_free_recvframe(struct recv_frame *precvframe, 
	list_add_tail(&precvframe->list, get_list_head(pfree_recv_queue));



	spin_unlock_bh(&pfree_recv_queue->lock);



	return _SUCCESS;

}



int _rtw_enqueue_recvframe(struct recv_frame *precvframe, struct __queue *queue)

drivers/staging/rtl8188eu/include/rtw_recv.h

+1 −2
Original line number Diff line number Diff line
@@ -231,8 +231,7 @@ struct recv_frame *_rtw_alloc_recvframe(struct __queue *pfree_recv_queue); 
struct recv_frame *rtw_alloc_recvframe(struct __queue *pfree_recv_queue);

void rtw_init_recvframe(struct recv_frame *precvframe,

			struct recv_priv *precvpriv);

int  rtw_free_recvframe(struct recv_frame *precvframe,

			struct __queue *pfree_recv_queue);

void rtw_free_recvframe(struct recv_frame *precvframe, struct __queue *pfree_recv_queue);

#define rtw_dequeue_recvframe(queue) rtw_alloc_recvframe(queue)

int _rtw_enqueue_recvframe(struct recv_frame *precvframe,

			   struct __queue *queue);