Commit ccc1439b authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Michael Ellerman
Browse files

powerpc/platforms/83xx/suspend: Prevent unloading the driver 



Returning an error in .remove() doesn't prevent a driver from being
unloaded. On unbind this only results in an error message, but the
device is remove anyhow.

I guess the author's idea of just returning -EPERM in .remove() was to
prevent unbinding a device. To achieve that set the suppress_bind_attrs
driver property and drop the useless .remove callback.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarChristophe Leroy <christophe.leroy@csgroup.eu>
Acked-by: default avatarScott Wood <oss@buserror.net>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220707061441.193869-2-u.kleine-koenig@pengutronix.de
parent fde345e4

arch/powerpc/platforms/83xx/suspend.c

+1 −6
Original line number Diff line number Diff line
@@ -421,18 +421,13 @@ static int pmc_probe(struct platform_device *ofdev) 
	return ret;

}



static int pmc_remove(struct platform_device *ofdev)

{

	return -EPERM;

};



static struct platform_driver pmc_driver = {

	.driver = {

		.name = "mpc83xx-pmc",

		.of_match_table = pmc_match,

		.suppress_bind_attrs = true,

	},

	.probe = pmc_probe,

	.remove = pmc_remove

};



builtin_platform_driver(pmc_driver);