Commit cb9bb7b2 authored by Johan Hovold's avatar Johan Hovold Committed by Alexandre Belloni
Browse files

rtc: pm8xxx: return IRQ_NONE on errors 



In the unlikely event that disabling the alarm and clearing the status
ever fails, return IRQ_NONE instead of IRQ_HANDLED.

Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20230202155448.6715-6-johan+linaro@kernel.org


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 8d273f33

drivers/rtc/rtc-pm8xxx.c

+3 −3
Original line number Diff line number Diff line
@@ -291,14 +291,14 @@ static irqreturn_t pm8xxx_alarm_trigger(int irq, void *dev_id) 
	rc = regmap_update_bits(rtc_dd->regmap, regs->alarm_ctrl,

				regs->alarm_en, 0);

	if (rc)

		goto out;

		return IRQ_NONE;



	/* Clear RTC alarm register */

	rc = regmap_update_bits(rtc_dd->regmap, regs->alarm_ctrl2,

				PM8xxx_RTC_ALARM_CLEAR, 0);

	if (rc)

		goto out;

out:

		return IRQ_NONE;



	return IRQ_HANDLED;

}