Commit cb559bb9 authored by Muhammad Usama Anjum's avatar Muhammad Usama Anjum Committed by Greg Kroah-Hartman
Browse files

serial: lantiq: store and compare return status correctly 



platform_get_irq() returns signed status. It should be stored and
compared as signed value before storing to unsigned variable. Implicit
conversion from signed to unsigned and then comparison with less than
zero is wrong as unsigned value can never be less than zero.

Fixes: f087f01c ("serial: lantiq: Use platform_get_irq() to get the interrupt")
Acked-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarMuhammad Usama Anjum <usama.anjum@collabora.com>
Link: https://lore.kernel.org/r/YcIf7+oSWWn34ND6@debian-BULLSEYE-live-builder-AMD64


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b4a29b94

drivers/tty/serial/lantiq.c

+14 −10
Original line number Diff line number Diff line
@@ -727,16 +727,20 @@ static int fetch_irq_lantiq(struct device *dev, struct ltq_uart_port *ltq_port) 
{

	struct uart_port *port = &ltq_port->port;

	struct platform_device *pdev = to_platform_device(dev);



	ltq_port->tx_irq = platform_get_irq(pdev, 0);

	if (ltq_port->tx_irq < 0)

		return ltq_port->tx_irq;

	ltq_port->rx_irq = platform_get_irq(pdev, 1);

	if (ltq_port->rx_irq < 0)

		return ltq_port->rx_irq;

	ltq_port->err_irq = platform_get_irq(pdev, 2);

	if (ltq_port->err_irq < 0)

		return ltq_port->err_irq;

	int irq;



	irq = platform_get_irq(pdev, 0);

	if (irq < 0)

		return irq;

	ltq_port->tx_irq = irq;

	irq = platform_get_irq(pdev, 1);

	if (irq < 0)

		return irq;

	ltq_port->rx_irq = irq;

	irq = platform_get_irq(pdev, 2);

	if (irq < 0)

		return irq;

	ltq_port->err_irq = irq;



	port->irq = ltq_port->tx_irq;