Unverified Commit c6a65861 authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown
Browse files

ASoC: Intel: Atom: sst-atom-controls: remove redundant assignments 



cppcheck complains of a possible NULL pointer dereference but setting
a pointer before using list_for_each_entry() is not useful.

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200813200147.61990-2-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 549ade57

sound/soc/intel/atom/sst-atom-controls.c

+2 −2
Original line number Diff line number Diff line
@@ -299,7 +299,7 @@ static int sst_find_and_send_pipe_algo(struct sst_data *drv, 
{

	int ret = 0;

	struct sst_algo_control *bc;

	struct sst_module *algo = NULL;

	struct sst_module *algo;



	dev_dbg(&drv->pdev->dev, "Enter: widget=%s\n", pipe);
@@ -602,7 +602,7 @@ static int sst_set_pipe_gain(struct sst_ids *ids, 
	int ret = 0;

	struct sst_gain_mixer_control *mc;

	struct sst_gain_value *gv;

	struct sst_module *gain = NULL;

	struct sst_module *gain;



	list_for_each_entry(gain, &ids->gain_list, node) {

		struct snd_kcontrol *kctl = gain->kctl;