Commit c6104b8e authored by Archit Taneja's avatar Archit Taneja Committed by Tomi Valkeinen
Browse files

OMAP: DSS2: DISPC: dispc_save_context() and dispc_restore_context() cleanup 



Iterate over manager and overlay id's to shorten dispc_save_context() and
dispc_restore_context().

Signed-off-by: default avatarArchit Taneja <archit@ti.com>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 4dd2da15

drivers/video/omap2/dss/dispc.c

+125 −277
Original line number Diff line number Diff line
@@ -171,172 +171,97 @@ static int dispc_get_ctx_loss_count(void) 


static void dispc_save_context(void)

{

	int i;

	int i, j;



	DSSDBG("dispc_save_context\n");



	SR(IRQENABLE);

	SR(CONTROL);

	SR(CONFIG);

	SR(DEFAULT_COLOR(OMAP_DSS_CHANNEL_LCD));

	SR(DEFAULT_COLOR(OMAP_DSS_CHANNEL_DIGIT));

	SR(TRANS_COLOR(OMAP_DSS_CHANNEL_LCD));

	SR(TRANS_COLOR(OMAP_DSS_CHANNEL_DIGIT));

	SR(LINE_NUMBER);

	SR(TIMING_H(OMAP_DSS_CHANNEL_LCD));

	SR(TIMING_V(OMAP_DSS_CHANNEL_LCD));

	SR(POL_FREQ(OMAP_DSS_CHANNEL_LCD));

	SR(DIVISORo(OMAP_DSS_CHANNEL_LCD));

	if (dss_has_feature(FEAT_GLOBAL_ALPHA))

		SR(GLOBAL_ALPHA);

	SR(SIZE_MGR(OMAP_DSS_CHANNEL_DIGIT));

	SR(SIZE_MGR(OMAP_DSS_CHANNEL_LCD));

	if (dss_has_feature(FEAT_MGR_LCD2)) {

		SR(CONTROL2);

		SR(DEFAULT_COLOR(OMAP_DSS_CHANNEL_LCD2));

		SR(TRANS_COLOR(OMAP_DSS_CHANNEL_LCD2));

		SR(SIZE_MGR(OMAP_DSS_CHANNEL_LCD2));

		SR(TIMING_H(OMAP_DSS_CHANNEL_LCD2));

		SR(TIMING_V(OMAP_DSS_CHANNEL_LCD2));

		SR(POL_FREQ(OMAP_DSS_CHANNEL_LCD2));

		SR(DIVISORo(OMAP_DSS_CHANNEL_LCD2));

		SR(CONFIG2);

	}



	SR(OVL_BA0(OMAP_DSS_GFX));

	SR(OVL_BA1(OMAP_DSS_GFX));

	SR(OVL_POSITION(OMAP_DSS_GFX));

	SR(OVL_SIZE(OMAP_DSS_GFX));

	SR(OVL_ATTRIBUTES(OMAP_DSS_GFX));

	SR(OVL_FIFO_THRESHOLD(OMAP_DSS_GFX));

	SR(OVL_ROW_INC(OMAP_DSS_GFX));

	SR(OVL_PIXEL_INC(OMAP_DSS_GFX));

	SR(OVL_WINDOW_SKIP(OMAP_DSS_GFX));

	SR(OVL_TABLE_BA(OMAP_DSS_GFX));

	for (i = 0; i < dss_feat_get_num_mgrs(); i++) {

		SR(DEFAULT_COLOR(i));

		SR(TRANS_COLOR(i));

		SR(SIZE_MGR(i));

		if (i == OMAP_DSS_CHANNEL_DIGIT)

			continue;

		SR(TIMING_H(i));

		SR(TIMING_V(i));

		SR(POL_FREQ(i));

		SR(DIVISORo(i));



	SR(DATA_CYCLE1(OMAP_DSS_CHANNEL_LCD));

	SR(DATA_CYCLE2(OMAP_DSS_CHANNEL_LCD));

	SR(DATA_CYCLE3(OMAP_DSS_CHANNEL_LCD));

		SR(DATA_CYCLE1(i));

		SR(DATA_CYCLE2(i));

		SR(DATA_CYCLE3(i));



		if (dss_has_feature(FEAT_CPR)) {

		SR(CPR_COEF_R(OMAP_DSS_CHANNEL_LCD));

		SR(CPR_COEF_G(OMAP_DSS_CHANNEL_LCD));

		SR(CPR_COEF_B(OMAP_DSS_CHANNEL_LCD));

	}

	if (dss_has_feature(FEAT_MGR_LCD2)) {

		if (dss_has_feature(FEAT_CPR)) {

			SR(CPR_COEF_B(OMAP_DSS_CHANNEL_LCD2));

			SR(CPR_COEF_G(OMAP_DSS_CHANNEL_LCD2));

			SR(CPR_COEF_R(OMAP_DSS_CHANNEL_LCD2));

			SR(CPR_COEF_R(i));

			SR(CPR_COEF_G(i));

			SR(CPR_COEF_B(i));

		}



		SR(DATA_CYCLE1(OMAP_DSS_CHANNEL_LCD2));

		SR(DATA_CYCLE2(OMAP_DSS_CHANNEL_LCD2));

		SR(DATA_CYCLE3(OMAP_DSS_CHANNEL_LCD2));

	}



	for (i = 0; i < dss_feat_get_num_ovls(); i++) {

		SR(OVL_BA0(i));

		SR(OVL_BA1(i));

		SR(OVL_POSITION(i));

		SR(OVL_SIZE(i));

		SR(OVL_ATTRIBUTES(i));

		SR(OVL_FIFO_THRESHOLD(i));

		SR(OVL_ROW_INC(i));

		SR(OVL_PIXEL_INC(i));

		if (dss_has_feature(FEAT_PRELOAD))

		SR(OVL_PRELOAD(OMAP_DSS_GFX));



	/* VID1 */

	SR(OVL_BA0(OMAP_DSS_VIDEO1));

	SR(OVL_BA1(OMAP_DSS_VIDEO1));

	SR(OVL_POSITION(OMAP_DSS_VIDEO1));

	SR(OVL_SIZE(OMAP_DSS_VIDEO1));

	SR(OVL_ATTRIBUTES(OMAP_DSS_VIDEO1));

	SR(OVL_FIFO_THRESHOLD(OMAP_DSS_VIDEO1));

	SR(OVL_ROW_INC(OMAP_DSS_VIDEO1));

	SR(OVL_PIXEL_INC(OMAP_DSS_VIDEO1));

	SR(OVL_FIR(OMAP_DSS_VIDEO1));

	SR(OVL_PICTURE_SIZE(OMAP_DSS_VIDEO1));

	SR(OVL_ACCU0(OMAP_DSS_VIDEO1));

	SR(OVL_ACCU1(OMAP_DSS_VIDEO1));



	for (i = 0; i < 8; i++)

		SR(OVL_FIR_COEF_H(OMAP_DSS_VIDEO1, i));



	for (i = 0; i < 8; i++)

		SR(OVL_FIR_COEF_HV(OMAP_DSS_VIDEO1, i));



	for (i = 0; i < 5; i++)

		SR(OVL_CONV_COEF(OMAP_DSS_VIDEO1, i));



	if (dss_has_feature(FEAT_FIR_COEF_V)) {

		for (i = 0; i < 8; i++)

			SR(OVL_FIR_COEF_V(OMAP_DSS_VIDEO1, i));

			SR(OVL_PRELOAD(i));

		if (i == OMAP_DSS_GFX) {

			SR(OVL_WINDOW_SKIP(i));

			SR(OVL_TABLE_BA(i));

			continue;

		}

		SR(OVL_FIR(i));

		SR(OVL_PICTURE_SIZE(i));

		SR(OVL_ACCU0(i));

		SR(OVL_ACCU1(i));



	if (dss_has_feature(FEAT_HANDLE_UV_SEPARATE)) {

		SR(OVL_BA0_UV(OMAP_DSS_VIDEO1));

		SR(OVL_BA1_UV(OMAP_DSS_VIDEO1));

		SR(OVL_FIR2(OMAP_DSS_VIDEO1));

		SR(OVL_ACCU2_0(OMAP_DSS_VIDEO1));

		SR(OVL_ACCU2_1(OMAP_DSS_VIDEO1));



		for (i = 0; i < 8; i++)

			SR(OVL_FIR_COEF_H2(OMAP_DSS_VIDEO1, i));



		for (i = 0; i < 8; i++)

			SR(OVL_FIR_COEF_HV2(OMAP_DSS_VIDEO1, i));

		for (j = 0; j < 8; j++)

			SR(OVL_FIR_COEF_H(i, j));



		for (i = 0; i < 8; i++)

			SR(OVL_FIR_COEF_V2(OMAP_DSS_VIDEO1, i));

	}

	if (dss_has_feature(FEAT_ATTR2))

		SR(OVL_ATTRIBUTES2(OMAP_DSS_VIDEO1));

		for (j = 0; j < 8; j++)

			SR(OVL_FIR_COEF_HV(i, j));



	if (dss_has_feature(FEAT_PRELOAD))

		SR(OVL_PRELOAD(OMAP_DSS_VIDEO1));



	/* VID2 */

	SR(OVL_BA0(OMAP_DSS_VIDEO2));

	SR(OVL_BA1(OMAP_DSS_VIDEO2));

	SR(OVL_POSITION(OMAP_DSS_VIDEO2));

	SR(OVL_SIZE(OMAP_DSS_VIDEO2));

	SR(OVL_ATTRIBUTES(OMAP_DSS_VIDEO2));

	SR(OVL_FIFO_THRESHOLD(OMAP_DSS_VIDEO2));

	SR(OVL_ROW_INC(OMAP_DSS_VIDEO2));

	SR(OVL_PIXEL_INC(OMAP_DSS_VIDEO2));

	SR(OVL_FIR(OMAP_DSS_VIDEO2));

	SR(OVL_PICTURE_SIZE(OMAP_DSS_VIDEO2));

	SR(OVL_ACCU0(OMAP_DSS_VIDEO2));

	SR(OVL_ACCU1(OMAP_DSS_VIDEO2));



	for (i = 0; i < 8; i++)

		SR(OVL_FIR_COEF_H(OMAP_DSS_VIDEO2, i));



	for (i = 0; i < 8; i++)

		SR(OVL_FIR_COEF_HV(OMAP_DSS_VIDEO2, i));



	for (i = 0; i < 5; i++)

		SR(OVL_CONV_COEF(OMAP_DSS_VIDEO2, i));

		for (j = 0; j < 5; j++)

			SR(OVL_CONV_COEF(i, j));



		if (dss_has_feature(FEAT_FIR_COEF_V)) {

		for (i = 0; i < 8; i++)

			SR(OVL_FIR_COEF_V(OMAP_DSS_VIDEO2, i));

			for (j = 0; j < 8; j++)

				SR(OVL_FIR_COEF_V(i, j));

		}



		if (dss_has_feature(FEAT_HANDLE_UV_SEPARATE)) {

		SR(OVL_BA0_UV(OMAP_DSS_VIDEO2));

		SR(OVL_BA1_UV(OMAP_DSS_VIDEO2));

		SR(OVL_FIR2(OMAP_DSS_VIDEO2));

		SR(OVL_ACCU2_0(OMAP_DSS_VIDEO2));

		SR(OVL_ACCU2_1(OMAP_DSS_VIDEO2));

			SR(OVL_BA0_UV(i));

			SR(OVL_BA1_UV(i));

			SR(OVL_FIR2(i));

			SR(OVL_ACCU2_0(i));

			SR(OVL_ACCU2_1(i));



		for (i = 0; i < 8; i++)

			SR(OVL_FIR_COEF_H2(OMAP_DSS_VIDEO2, i));

			for (j = 0; j < 8; j++)

				SR(OVL_FIR_COEF_H2(i, j));



		for (i = 0; i < 8; i++)

			SR(OVL_FIR_COEF_HV2(OMAP_DSS_VIDEO2, i));

			for (j = 0; j < 8; j++)

				SR(OVL_FIR_COEF_HV2(i, j));



		for (i = 0; i < 8; i++)

			SR(OVL_FIR_COEF_V2(OMAP_DSS_VIDEO2, i));

			for (j = 0; j < 8; j++)

				SR(OVL_FIR_COEF_V2(i, j));

		}

		if (dss_has_feature(FEAT_ATTR2))

		SR(OVL_ATTRIBUTES2(OMAP_DSS_VIDEO2));



	if (dss_has_feature(FEAT_PRELOAD))

		SR(OVL_PRELOAD(OMAP_DSS_VIDEO2));

			SR(OVL_ATTRIBUTES2(i));

	}



	if (dss_has_feature(FEAT_CORE_CLK_DIV))

		SR(DIVISOR);
@@ -349,7 +274,7 @@ static void dispc_save_context(void) 


static void dispc_restore_context(void)

{

	int i, ctx;

	int i, j, ctx;



	DSSDBG("dispc_restore_context\n");
@@ -367,165 +292,88 @@ static void dispc_restore_context(void) 
	/*RR(IRQENABLE);*/

	/*RR(CONTROL);*/

	RR(CONFIG);

	RR(DEFAULT_COLOR(OMAP_DSS_CHANNEL_LCD));

	RR(DEFAULT_COLOR(OMAP_DSS_CHANNEL_DIGIT));

	RR(TRANS_COLOR(OMAP_DSS_CHANNEL_LCD));

	RR(TRANS_COLOR(OMAP_DSS_CHANNEL_DIGIT));

	RR(LINE_NUMBER);

	RR(TIMING_H(OMAP_DSS_CHANNEL_LCD));

	RR(TIMING_V(OMAP_DSS_CHANNEL_LCD));

	RR(POL_FREQ(OMAP_DSS_CHANNEL_LCD));

	RR(DIVISORo(OMAP_DSS_CHANNEL_LCD));

	if (dss_has_feature(FEAT_GLOBAL_ALPHA))

		RR(GLOBAL_ALPHA);

	RR(SIZE_MGR(OMAP_DSS_CHANNEL_DIGIT));

	RR(SIZE_MGR(OMAP_DSS_CHANNEL_LCD));

	if (dss_has_feature(FEAT_MGR_LCD2)) {

		RR(DEFAULT_COLOR(OMAP_DSS_CHANNEL_LCD2));

		RR(TRANS_COLOR(OMAP_DSS_CHANNEL_LCD2));

		RR(SIZE_MGR(OMAP_DSS_CHANNEL_LCD2));

		RR(TIMING_H(OMAP_DSS_CHANNEL_LCD2));

		RR(TIMING_V(OMAP_DSS_CHANNEL_LCD2));

		RR(POL_FREQ(OMAP_DSS_CHANNEL_LCD2));

		RR(DIVISORo(OMAP_DSS_CHANNEL_LCD2));

	if (dss_has_feature(FEAT_MGR_LCD2))

		RR(CONFIG2);

	}



	RR(OVL_BA0(OMAP_DSS_GFX));

	RR(OVL_BA1(OMAP_DSS_GFX));

	RR(OVL_POSITION(OMAP_DSS_GFX));

	RR(OVL_SIZE(OMAP_DSS_GFX));

	RR(OVL_ATTRIBUTES(OMAP_DSS_GFX));

	RR(OVL_FIFO_THRESHOLD(OMAP_DSS_GFX));

	RR(OVL_ROW_INC(OMAP_DSS_GFX));

	RR(OVL_PIXEL_INC(OMAP_DSS_GFX));

	RR(OVL_WINDOW_SKIP(OMAP_DSS_GFX));

	RR(OVL_TABLE_BA(OMAP_DSS_GFX));





	RR(DATA_CYCLE1(OMAP_DSS_CHANNEL_LCD));

	RR(DATA_CYCLE2(OMAP_DSS_CHANNEL_LCD));

	RR(DATA_CYCLE3(OMAP_DSS_CHANNEL_LCD));

	for (i = 0; i < dss_feat_get_num_mgrs(); i++) {

		RR(DEFAULT_COLOR(i));

		RR(TRANS_COLOR(i));

		RR(SIZE_MGR(i));

		if (i == OMAP_DSS_CHANNEL_DIGIT)

			continue;

		RR(TIMING_H(i));

		RR(TIMING_V(i));

		RR(POL_FREQ(i));

		RR(DIVISORo(i));



	if (dss_has_feature(FEAT_CPR)) {

		RR(CPR_COEF_R(OMAP_DSS_CHANNEL_LCD));

		RR(CPR_COEF_G(OMAP_DSS_CHANNEL_LCD));

		RR(CPR_COEF_B(OMAP_DSS_CHANNEL_LCD));

	}

	if (dss_has_feature(FEAT_MGR_LCD2)) {

		RR(DATA_CYCLE1(OMAP_DSS_CHANNEL_LCD2));

		RR(DATA_CYCLE2(OMAP_DSS_CHANNEL_LCD2));

		RR(DATA_CYCLE3(OMAP_DSS_CHANNEL_LCD2));

		RR(DATA_CYCLE1(i));

		RR(DATA_CYCLE2(i));

		RR(DATA_CYCLE3(i));



		if (dss_has_feature(FEAT_CPR)) {

			RR(CPR_COEF_B(OMAP_DSS_CHANNEL_LCD2));

			RR(CPR_COEF_G(OMAP_DSS_CHANNEL_LCD2));

			RR(CPR_COEF_R(OMAP_DSS_CHANNEL_LCD2));

			RR(CPR_COEF_R(i));

			RR(CPR_COEF_G(i));

			RR(CPR_COEF_B(i));

		}

	}



	for (i = 0; i < dss_feat_get_num_ovls(); i++) {

		RR(OVL_BA0(i));

		RR(OVL_BA1(i));

		RR(OVL_POSITION(i));

		RR(OVL_SIZE(i));

		RR(OVL_ATTRIBUTES(i));

		RR(OVL_FIFO_THRESHOLD(i));

		RR(OVL_ROW_INC(i));

		RR(OVL_PIXEL_INC(i));

		if (dss_has_feature(FEAT_PRELOAD))

		RR(OVL_PRELOAD(OMAP_DSS_GFX));



	/* VID1 */

	RR(OVL_BA0(OMAP_DSS_VIDEO1));

	RR(OVL_BA1(OMAP_DSS_VIDEO1));

	RR(OVL_POSITION(OMAP_DSS_VIDEO1));

	RR(OVL_SIZE(OMAP_DSS_VIDEO1));

	RR(OVL_ATTRIBUTES(OMAP_DSS_VIDEO1));

	RR(OVL_FIFO_THRESHOLD(OMAP_DSS_VIDEO1));

	RR(OVL_ROW_INC(OMAP_DSS_VIDEO1));

	RR(OVL_PIXEL_INC(OMAP_DSS_VIDEO1));

	RR(OVL_FIR(OMAP_DSS_VIDEO1));

	RR(OVL_PICTURE_SIZE(OMAP_DSS_VIDEO1));

	RR(OVL_ACCU0(OMAP_DSS_VIDEO1));

	RR(OVL_ACCU1(OMAP_DSS_VIDEO1));



	for (i = 0; i < 8; i++)

		RR(OVL_FIR_COEF_H(OMAP_DSS_VIDEO1, i));



	for (i = 0; i < 8; i++)

		RR(OVL_FIR_COEF_HV(OMAP_DSS_VIDEO1, i));



	for (i = 0; i < 5; i++)

		RR(OVL_CONV_COEF(OMAP_DSS_VIDEO1, i));



	if (dss_has_feature(FEAT_FIR_COEF_V)) {

		for (i = 0; i < 8; i++)

			RR(OVL_FIR_COEF_V(OMAP_DSS_VIDEO1, i));

			RR(OVL_PRELOAD(i));

		if (i == OMAP_DSS_GFX) {

			RR(OVL_WINDOW_SKIP(i));

			RR(OVL_TABLE_BA(i));

			continue;

		}

		RR(OVL_FIR(i));

		RR(OVL_PICTURE_SIZE(i));

		RR(OVL_ACCU0(i));

		RR(OVL_ACCU1(i));



	if (dss_has_feature(FEAT_HANDLE_UV_SEPARATE)) {

		RR(OVL_BA0_UV(OMAP_DSS_VIDEO1));

		RR(OVL_BA1_UV(OMAP_DSS_VIDEO1));

		RR(OVL_FIR2(OMAP_DSS_VIDEO1));

		RR(OVL_ACCU2_0(OMAP_DSS_VIDEO1));

		RR(OVL_ACCU2_1(OMAP_DSS_VIDEO1));



		for (i = 0; i < 8; i++)

			RR(OVL_FIR_COEF_H2(OMAP_DSS_VIDEO1, i));



		for (i = 0; i < 8; i++)

			RR(OVL_FIR_COEF_HV2(OMAP_DSS_VIDEO1, i));

		for (j = 0; j < 8; j++)

			RR(OVL_FIR_COEF_H(i, j));



		for (i = 0; i < 8; i++)

			RR(OVL_FIR_COEF_V2(OMAP_DSS_VIDEO1, i));

	}

	if (dss_has_feature(FEAT_ATTR2))

		RR(OVL_ATTRIBUTES2(OMAP_DSS_VIDEO1));

		for (j = 0; j < 8; j++)

			RR(OVL_FIR_COEF_HV(i, j));



	if (dss_has_feature(FEAT_PRELOAD))

		RR(OVL_PRELOAD(OMAP_DSS_VIDEO1));



	/* VID2 */

	RR(OVL_BA0(OMAP_DSS_VIDEO2));

	RR(OVL_BA1(OMAP_DSS_VIDEO2));

	RR(OVL_POSITION(OMAP_DSS_VIDEO2));

	RR(OVL_SIZE(OMAP_DSS_VIDEO2));

	RR(OVL_ATTRIBUTES(OMAP_DSS_VIDEO2));

	RR(OVL_FIFO_THRESHOLD(OMAP_DSS_VIDEO2));

	RR(OVL_ROW_INC(OMAP_DSS_VIDEO2));

	RR(OVL_PIXEL_INC(OMAP_DSS_VIDEO2));

	RR(OVL_FIR(OMAP_DSS_VIDEO2));

	RR(OVL_PICTURE_SIZE(OMAP_DSS_VIDEO2));

	RR(OVL_ACCU0(OMAP_DSS_VIDEO2));

	RR(OVL_ACCU1(OMAP_DSS_VIDEO2));



	for (i = 0; i < 8; i++)

		RR(OVL_FIR_COEF_H(OMAP_DSS_VIDEO2, i));



	for (i = 0; i < 8; i++)

		RR(OVL_FIR_COEF_HV(OMAP_DSS_VIDEO2, i));



	for (i = 0; i < 5; i++)

		RR(OVL_CONV_COEF(OMAP_DSS_VIDEO2, i));

		for (j = 0; j < 5; j++)

			RR(OVL_CONV_COEF(i, j));



		if (dss_has_feature(FEAT_FIR_COEF_V)) {

		for (i = 0; i < 8; i++)

			RR(OVL_FIR_COEF_V(OMAP_DSS_VIDEO2, i));

			for (j = 0; j < 8; j++)

				RR(OVL_FIR_COEF_V(i, j));

		}



		if (dss_has_feature(FEAT_HANDLE_UV_SEPARATE)) {

		RR(OVL_BA0_UV(OMAP_DSS_VIDEO2));

		RR(OVL_BA1_UV(OMAP_DSS_VIDEO2));

		RR(OVL_FIR2(OMAP_DSS_VIDEO2));

		RR(OVL_ACCU2_0(OMAP_DSS_VIDEO2));

		RR(OVL_ACCU2_1(OMAP_DSS_VIDEO2));

			RR(OVL_BA0_UV(i));

			RR(OVL_BA1_UV(i));

			RR(OVL_FIR2(i));

			RR(OVL_ACCU2_0(i));

			RR(OVL_ACCU2_1(i));



		for (i = 0; i < 8; i++)

			RR(OVL_FIR_COEF_H2(OMAP_DSS_VIDEO2, i));

			for (j = 0; j < 8; j++)

				RR(OVL_FIR_COEF_H2(i, j));



		for (i = 0; i < 8; i++)

			RR(OVL_FIR_COEF_HV2(OMAP_DSS_VIDEO2, i));

			for (j = 0; j < 8; j++)

				RR(OVL_FIR_COEF_HV2(i, j));



		for (i = 0; i < 8; i++)

			RR(OVL_FIR_COEF_V2(OMAP_DSS_VIDEO2, i));

			for (j = 0; j < 8; j++)

				RR(OVL_FIR_COEF_V2(i, j));

		}

		if (dss_has_feature(FEAT_ATTR2))

		RR(OVL_ATTRIBUTES2(OMAP_DSS_VIDEO2));



	if (dss_has_feature(FEAT_PRELOAD))

		RR(OVL_PRELOAD(OMAP_DSS_VIDEO2));

			RR(OVL_ATTRIBUTES2(i));

	}



	if (dss_has_feature(FEAT_CORE_CLK_DIV))

		RR(DIVISOR);