Commit be6d43ef authored by Jinjie Ruan's avatar Jinjie Ruan Committed by Nishanth Menon
Browse files

firmware: ti_sci: Use list_for_each_entry() helper 



Convert list_for_each() to list_for_each_entry() so that the p
list_head pointer and list_entry() call are no longer needed, which
can reduce a few lines of code. No functional changed.

Signed-off-by: default avatarJinjie Ruan <ruanjinjie@huawei.com>
Link: https://lore.kernel.org/r/20230830090344.528818-1-ruanjinjie@huawei.com


Signed-off-by: default avatarNishanth Menon <nm@ti.com>
parent 0bb80ecc

drivers/firmware/ti_sci.c

+2 −6
Original line number Diff line number Diff line
@@ -2886,7 +2886,6 @@ static void ti_sci_setup_ops(struct ti_sci_info *info) 
const struct ti_sci_handle *ti_sci_get_handle(struct device *dev)

{

	struct device_node *ti_sci_np;

	struct list_head *p;

	struct ti_sci_handle *handle = NULL;

	struct ti_sci_info *info;
@@ -2901,8 +2900,7 @@ const struct ti_sci_handle *ti_sci_get_handle(struct device *dev) 
	}



	mutex_lock(&ti_sci_list_mutex);

	list_for_each(p, &ti_sci_list) {

		info = list_entry(p, struct ti_sci_info, node);

	list_for_each_entry(info, &ti_sci_list, node) {

		if (ti_sci_np == info->dev->of_node) {

			handle = &info->handle;

			info->users++;
@@ -3012,7 +3010,6 @@ const struct ti_sci_handle *ti_sci_get_by_phandle(struct device_node *np, 
	struct ti_sci_handle *handle = NULL;

	struct device_node *ti_sci_np;

	struct ti_sci_info *info;

	struct list_head *p;



	if (!np) {

		pr_err("I need a device pointer\n");
@@ -3024,8 +3021,7 @@ const struct ti_sci_handle *ti_sci_get_by_phandle(struct device_node *np, 
		return ERR_PTR(-ENODEV);



	mutex_lock(&ti_sci_list_mutex);

	list_for_each(p, &ti_sci_list) {

		info = list_entry(p, struct ti_sci_info, node);

	list_for_each_entry(info, &ti_sci_list, node) {

		if (ti_sci_np == info->dev->of_node) {

			handle = &info->handle;

			info->users++;