Commit bdef417d authored by Xiaomeng Tong's avatar Xiaomeng Tong Committed by Patrik Jakobsson
Browse files

gma500: fix an incorrect NULL check on list iterator 



The bug is here:
	return crtc;

The list iterator value 'crtc' will *always* be set and non-NULL by
list_for_each_entry(), so it is incorrect to assume that the iterator
value will be NULL if the list is empty or no element is found.

To fix the bug, return 'crtc' when found, otherwise return NULL.

Cc: stable@vger.kernel.org
fixes: 89c78134 ("gma500: Add Poulsbo support")
Signed-off-by: default avatarXiaomeng Tong <xiam0nd.tong@gmail.com>
Signed-off-by: default avatarPatrik Jakobsson <patrik.r.jakobsson@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220327052028.2013-1-xiam0nd.tong@gmail.com
parent 77ef271f

drivers/gpu/drm/gma500/psb_intel_display.c

+4 −3
Original line number Diff line number Diff line
@@ -524,15 +524,16 @@ void psb_intel_crtc_init(struct drm_device *dev, int pipe, 


struct drm_crtc *psb_intel_get_crtc_from_pipe(struct drm_device *dev, int pipe)

{

	struct drm_crtc *crtc = NULL;

	struct drm_crtc *crtc;



	list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) {

		struct gma_crtc *gma_crtc = to_gma_crtc(crtc);



		if (gma_crtc->pipe == pipe)

			break;

	}

			return crtc;

	}

	return NULL;

}



int gma_connector_clones(struct drm_device *dev, int type_mask)

{