Commit b67d1966 authored by Hangyu Hua's avatar Hangyu Hua Committed by Greg Kroah-Hartman
Browse files

char: xillybus: fix a refcount leak in cleanup_dev() 



usb_get_dev is called in xillyusb_probe. So it is better to call
usb_put_dev before xdev is released.

Acked-by: default avatarEli Billauer <eli.billauer@gmail.com>
Signed-off-by: default avatarHangyu Hua <hbh25y@gmail.com>
Link: https://lore.kernel.org/r/20220406075703.23464-1-hbh25y@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 88517757

drivers/char/xillybus/xillyusb.c

+1 −0
Original line number Diff line number Diff line
@@ -549,6 +549,7 @@ static void cleanup_dev(struct kref *kref) 
	if (xdev->workq)

		destroy_workqueue(xdev->workq);



	usb_put_dev(xdev->udev);

	kfree(xdev->channels); /* Argument may be NULL, and that's fine */

	kfree(xdev);

}