Commit 9a0f1341 authored by Paul Cercueil's avatar Paul Cercueil Committed by Linus Walleij
Browse files

pinctrl: ingenic: Add irq_{request,release}_resources callbacks 



These are called when a GPIO is to be used as IRQ.

Without these custom callbacks, when an interrupt is requested directly
and not through gpiod_to_irq(), the request fails because the GPIO is
not necesarily in input mode. These callbacks simply enforce that the
requested GPIO is in input mode.

Signed-off-by: default avatarPaul Cercueil <paul@crapouillou.net>
Link: https://lore.kernel.org/r/20200503164549.163884-1-paul@crapouillou.net


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 8068071c

drivers/pinctrl/pinctrl-ingenic.c

+21 −0
Original line number Diff line number Diff line
@@ -1977,6 +1977,25 @@ static const struct pinctrl_ops ingenic_pctlops = { 
	.dt_free_map = pinconf_generic_dt_free_map,

};



static int ingenic_gpio_irq_request(struct irq_data *data)

{

	struct gpio_chip *gpio_chip = irq_data_get_irq_chip_data(data);

	int ret;



	ret = ingenic_gpio_direction_input(gpio_chip, data->hwirq);

	if (ret)

		return ret;



	return gpiochip_reqres_irq(gpio_chip, data->hwirq);

}



static void ingenic_gpio_irq_release(struct irq_data *data)

{

	struct gpio_chip *gpio_chip = irq_data_get_irq_chip_data(data);



	return gpiochip_relres_irq(gpio_chip, data->hwirq);

}



static int ingenic_pinmux_set_pin_fn(struct ingenic_pinctrl *jzpc,

		int pin, int func)

{
@@ -2338,6 +2357,8 @@ static int __init ingenic_gpio_probe(struct ingenic_pinctrl *jzpc, 
	jzgc->irq_chip.irq_ack = ingenic_gpio_irq_ack;

	jzgc->irq_chip.irq_set_type = ingenic_gpio_irq_set_type;

	jzgc->irq_chip.irq_set_wake = ingenic_gpio_irq_set_wake;

	jzgc->irq_chip.irq_request_resources = ingenic_gpio_irq_request;

	jzgc->irq_chip.irq_release_resources = ingenic_gpio_irq_release;

	jzgc->irq_chip.flags = IRQCHIP_MASK_ON_SUSPEND;



	girq = &jzgc->gc.irq;