Commit 9923a6da authored by Yang Li's avatar Yang Li Committed by Michael Ellerman
Browse files

powerpc/sstep: Use bitwise instead of arithmetic operator for flags 



Fix the following coccinelle warnings:
./arch/powerpc/lib/sstep.c:1090:20-21: WARNING: sum of probable
bitmasks, consider |
./arch/powerpc/lib/sstep.c:1115:20-21: WARNING: sum of probable
bitmasks, consider |
./arch/powerpc/lib/sstep.c:1134:20-21: WARNING: sum of probable
bitmasks, consider |

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
Signed-off-by: default avatarChristophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/1613811455-2457-1-git-send-email-yang.lee@linux.alibaba.com
parent 22f8e625

arch/powerpc/lib/sstep.c

+3 −3
Original line number Diff line number Diff line
@@ -1166,7 +1166,7 @@ static nokprobe_inline void add_with_carry(const struct pt_regs *regs, 


	if (carry_in)

		++val;

	op->type = COMPUTE + SETREG + SETXER;

	op->type = COMPUTE | SETREG | SETXER;

	op->reg = rd;

	op->val = val;

	val = truncate_if_32bit(regs->msr, val);
@@ -1187,7 +1187,7 @@ static nokprobe_inline void do_cmp_signed(const struct pt_regs *regs, 
{

	unsigned int crval, shift;



	op->type = COMPUTE + SETCC;

	op->type = COMPUTE | SETCC;

	crval = (regs->xer >> 31) & 1;		/* get SO bit */

	if (v1 < v2)

		crval |= 8;
@@ -1206,7 +1206,7 @@ static nokprobe_inline void do_cmp_unsigned(const struct pt_regs *regs, 
{

	unsigned int crval, shift;



	op->type = COMPUTE + SETCC;

	op->type = COMPUTE | SETCC;

	crval = (regs->xer >> 31) & 1;		/* get SO bit */

	if (v1 < v2)

		crval |= 8;