Commit 98c7a166 authored by Mark Rutland's avatar Mark Rutland Committed by Will Deacon
Browse files

arm64: smp: remove pointless secondary_data maintenance 



All reads and writes of secondary_data occur with the MMU on, using
coherent attributes, so there's no need to perform any cache maintenance
for this.

There should be no functional change as a result of this patch.

Signed-off-by: default avatarMark Rutland <mark.rutland@arm.com>
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: James Morse <james.morse@arm.com>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Suzuki Poulose <suzuki.poulose@arm.com>
Cc: Will Deacon <will@kernel.org>
Reviewed-by: default avatarArd Biesheuvel <ardb@kernel.org>
Link: https://lore.kernel.org/r/20210520115031.18509-4-mark.rutland@arm.com


Signed-off-by: default avatarWill Deacon <will@kernel.org>
parent e176e267

arch/arm64/kernel/smp.c

+0 −2
Original line number Diff line number Diff line
@@ -122,7 +122,6 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle) 
	secondary_data.task = idle;

	secondary_data.stack = task_stack_page(idle) + THREAD_SIZE;

	update_cpu_boot_status(CPU_MMU_OFF);

	__flush_dcache_area(&secondary_data, sizeof(secondary_data));



	/* Now bring the CPU into our world */

	ret = boot_secondary(cpu, idle);
@@ -143,7 +142,6 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle) 
	pr_crit("CPU%u: failed to come online\n", cpu);

	secondary_data.task = NULL;

	secondary_data.stack = NULL;

	__flush_dcache_area(&secondary_data, sizeof(secondary_data));

	status = READ_ONCE(secondary_data.status);

	if (status == CPU_MMU_OFF)

		status = READ_ONCE(__early_cpu_boot_status);