Commit 97775557 authored by Eric Biggers's avatar Eric Biggers Committed by Herbert Xu
Browse files

crypto: sun4i-ss - remove unnecessary alignmask for ahashes 



The crypto API's support for alignmasks for ahash algorithms is nearly
useless, as its only effect is to cause the API to align the key and
result buffers.  The drivers that happen to be specifying an alignmask
for ahash rarely actually need it.  When they do, it's easily fixable,
especially considering that these buffers cannot be used for DMA.

In preparation for removing alignmask support from ahash, this patch
makes the sun4i-ss driver no longer use it.  This driver didn't actually
rely on it; it only writes to the result buffer in sun4i_hash(), already
using the unaligned access helpers.  And this driver only supports
unkeyed hash algorithms, so the key buffer need not be considered.

Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
Acked-by: default avatarCorentin Labbe <clabbe.montjoie@gmail.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent acd77995

drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c

+0 −2
Original line number Diff line number Diff line
@@ -49,7 +49,6 @@ static struct sun4i_ss_alg_template ss_algs[] = { 
				.cra_name = "md5",

				.cra_driver_name = "md5-sun4i-ss",

				.cra_priority = 300,

				.cra_alignmask = 3,

				.cra_blocksize = MD5_HMAC_BLOCK_SIZE,

				.cra_ctxsize = sizeof(struct sun4i_req_ctx),

				.cra_module = THIS_MODULE,
@@ -76,7 +75,6 @@ static struct sun4i_ss_alg_template ss_algs[] = { 
				.cra_name = "sha1",

				.cra_driver_name = "sha1-sun4i-ss",

				.cra_priority = 300,

				.cra_alignmask = 3,

				.cra_blocksize = SHA1_BLOCK_SIZE,

				.cra_ctxsize = sizeof(struct sun4i_req_ctx),

				.cra_module = THIS_MODULE,