Commit 9248aa90 authored by Dafna Hirschfeld's avatar Dafna Hirschfeld Committed by Greg Kroah-Hartman
Browse files

habanalabs: enforce alignment upon registers access through debugfs 



When accessing the configuration registers through debugfs,
it is only allowed to access aligned address.
Fail if address is not aligned.

Signed-off-by: default avatarDafna Hirschfeld <dhirschfeld@habana.ai>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ee8a10c8

drivers/misc/habanalabs/common/device.c

+5 −0
Original line number Diff line number Diff line
@@ -94,6 +94,11 @@ int hl_access_cfg_region(struct hl_device *hdev, u64 addr, u64 *val, 
	struct pci_mem_region *cfg_region = &hdev->pci_mem_region[PCI_REGION_CFG];

	u32 val_h, val_l;



	if (!IS_ALIGNED(addr, sizeof(u32))) {

		dev_err(hdev->dev, "address %#llx not a multiple of %zu\n", addr, sizeof(u32));

		return -EINVAL;

	}



	switch (acc_type) {

	case DEBUGFS_READ32:

		*val = RREG32(addr - cfg_region->region_base);