Commit 7ee7482e authored by Jing Yao's avatar Jing Yao Committed by Greg Kroah-Hartman
Browse files

serial: 8250: replace snprintf in show functions with sysfs_emit 



coccicheck complains about the use of snprintf() in sysfs show
functions:
WARNING use scnprintf or sprintf

Use sysfs_emit instead of scnprintf or sprintf makes more sense.

Reported-by: default avatarZeal Robot <zealci@zte.com.cn>
Reviewed-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarJing Yao <yao.jing2@zte.com.cn>
Link: https://lore.kernel.org/r/20211104114754.30983-1-yao.jing2@zte.com.cn


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 13605725

drivers/tty/serial/8250/8250_port.c

+1 −1
Original line number Diff line number Diff line
@@ -3099,7 +3099,7 @@ static ssize_t rx_trig_bytes_show(struct device *dev, 
	if (rxtrig_bytes < 0)

		return rxtrig_bytes;



	return snprintf(buf, PAGE_SIZE, "%d\n", rxtrig_bytes);

	return sysfs_emit(buf, "%d\n", rxtrig_bytes);

}



static int do_set_rxtrig(struct tty_port *port, unsigned char bytes)