Commit 71bea057 authored by Cristian Marussi's avatar Cristian Marussi Committed by Sudeep Holla
Browse files

firmware: arm_scmi: Add checks for min/max limits in PERFORMANCE_LIMITS_SET 

Starting with SCMI v3.1, the PERFORMANCE_LIMITS_SET command allows a user
to request only one between max and min ranges to be changed, while leaving
the other untouched if set to zero in the request. Anyway SCMI v3.1 states
also explicitly that you cannot leave both of those unchanged (zeroed) when
issuing such command, so add a proper check for this condition.

Link: https://lore.kernel.org/r/20220330150551.2573938-23-cristian.marussi@arm.com


Signed-off-by: default avatarCristian Marussi <cristian.marussi@arm.com>
[sudeep.holla: Dropped check for v3.0 and above to make the check
	unconditional, updated the subject accordingly]
Signed-off-by: default avatarSudeep Holla <sudeep.holla@arm.com>
parent 3630cd81

drivers/firmware/arm_scmi/perf.c

+3 −0
Original line number Diff line number Diff line
@@ -423,6 +423,9 @@ static int scmi_perf_limits_set(const struct scmi_protocol_handle *ph, 
	struct scmi_perf_info *pi = ph->get_priv(ph);

	struct perf_dom_info *dom = pi->dom_info + domain;



	if (PROTOCOL_REV_MAJOR(pi->version) >= 0x3 && !max_perf && !min_perf)

		return -EINVAL;



	if (dom->fc_info && dom->fc_info->limit_set_addr) {

		iowrite32(max_perf, dom->fc_info->limit_set_addr);

		iowrite32(min_perf, dom->fc_info->limit_set_addr + 4);