Commit 7040557c authored Jan 21, 2021 by Lee Jones Committed by Jason Gunthorpe Jan 22, 2021

RDMA/hw/qib/qib_mad: Fix a few misspellings and supply missing descriptions

Fixes the following W=1 kernel build warning(s):

drivers/infiniband/hw/qib/qib_mad.c:896: warning: Function parameter or member 'ppd' not described in 'rm_pkey'
drivers/infiniband/hw/qib/qib_mad.c:896: warning: Excess function parameter 'dd' description in 'rm_pkey'
drivers/infiniband/hw/qib/qib_mad.c:926: warning: Function parameter or member 'ppd' not described in 'add_pkey'
drivers/infiniband/hw/qib/qib_mad.c:926: warning: Excess function parameter 'dd' description in 'add_pkey'
drivers/infiniband/hw/qib/qib_mad.c:2365: warning: Function parameter or member 'in' not described in 'qib_process_mad'
drivers/infiniband/hw/qib/qib_mad.c:2365: warning: Function parameter or member 'out' not described in 'qib_process_mad'
drivers/infiniband/hw/qib/qib_mad.c:2365: warning: Function parameter or member 'out_mad_size' not described in 'qib_process_mad'
drivers/infiniband/hw/qib/qib_mad.c:2365: warning: Function parameter or member 'out_mad_pkey_index' not described in 'qib_process_mad'
drivers/infiniband/hw/qib/qib_mad.c:2365: warning: Excess function parameter 'in_mad' description in 'qib_process_mad'
drivers/infiniband/hw/qib/qib_mad.c:2365: warning: Excess function parameter 'out_mad' description in 'qib_process_mad'

Link: https://lore.kernel.org/r/20210121094519.2044049-10-lee.jones@linaro.org

Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
Cc: Doug Ledford <dledford@redhat.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: linux-rdma@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

parent aab5a7e9

drivers/infiniband/hw/qib/qib_mad.c

+6 −4

Original line number	Diff line number	Diff line
		@@ -886,7 +886,7 @@ static int subn_set_portinfo(struct ib_smp smp, struct ib_device ibdev,

		/**
		* rm_pkey - decrecment the reference count for the given PKEY
		* @dd: the qlogic_ib device
		* @ppd: the qlogic_ib device
		* @key: the PKEY index
		*
		* Return true if this was the last reference and the hardware table entry
		@@ -916,7 +916,7 @@ static int rm_pkey(struct qib_pportdata *ppd, u16 key)

		/**
		* add_pkey - add the given PKEY to the hardware table
		* @dd: the qlogic_ib device
		* @ppd: the qlogic_ib device
		* @key: the PKEY
		*
		* Return an error code if unable to add the entry, zero if no change,
		@@ -2346,8 +2346,10 @@ static int process_cc(struct ib_device *ibdev, int mad_flags,
		* @port: the port number this packet came in on
		* @in_wc: the work completion entry for this packet
		* @in_grh: the global route header for this packet
		* @in_mad: the incoming MAD
		* @out_mad: any outgoing MAD reply
		* @in: the incoming MAD
		* @out: any outgoing MAD reply
		* @out_mad_size: size of the outgoing MAD reply
		* @out_mad_pkey_index: unused
		*
		* Returns IB_MAD_RESULT_SUCCESS if this is a MAD that we are not
		* interested in processing.